From: Yao Qi <yao@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: New ARI warning Wed Apr 27 01:54:55 UTC 2011
Date: Wed, 27 Apr 2011 15:48:00 -0000 [thread overview]
Message-ID: <4DB83ACB.6080503@codesourcery.com> (raw)
In-Reply-To: <20110427150815.GB2489@adacore.com>
On 04/27/2011 11:08 PM, Joel Brobecker wrote:
>> sys/wait.h is included for macro __WALL. However, we can safely remove
>> this include from common/linux-ptrace.h because either sys/wait.h or
>> gdb_wait.h is included before including linux-ptrace.h in linux-nat.c
>> and linux-low.c.
>
> That's the only pragmatic answer that we have right now, but I do
> think that this is an extremely bad practice. Or maybe I'm biased
> by my past as an Ada developer...
>
> Sooner or later, we'll have to move these header files to the common
> area as well.
>
Yes, I agree. So far, gdb code is using gdb_wait.h and gdbserver is
using sys/wait.h. gdb_wait.h looks quite independent of gdb or
gdbserver. Is there any known reason that we can't use gdb_wait.h in
gdbserver? I don't see any.
--
Yao (é½å°§)
next prev parent reply other threads:[~2011-04-27 15:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 1:55 GDB Administrator
2011-04-27 3:16 ` Yao Qi
2011-04-27 14:53 ` Tom Tromey
2011-04-27 15:08 ` Joel Brobecker
2011-04-27 15:48 ` Yao Qi [this message]
2011-04-27 16:18 ` Joel Brobecker
2011-04-27 16:44 ` Mark Kettenis
2011-04-27 16:59 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB83ACB.6080503@codesourcery.com \
--to=yao@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox