Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: New ARI warning Wed Apr 27 01:54:55 UTC 2011
Date: Wed, 27 Apr 2011 15:08:00 -0000	[thread overview]
Message-ID: <20110427150815.GB2489@adacore.com> (raw)
In-Reply-To: <4DB78A74.9060105@codesourcery.com>

> sys/wait.h is included for macro __WALL.  However, we can safely remove
> this include from common/linux-ptrace.h because either sys/wait.h or
> gdb_wait.h is included before including linux-ptrace.h in linux-nat.c
> and linux-low.c.

That's the only pragmatic answer that we have right now, but I do
think that this is an extremely bad practice. Or maybe I'm biased
by my past as an Ada developer...

Sooner or later, we'll have to move these header files to the common
area as well.

-- 
Joel


  parent reply	other threads:[~2011-04-27 15:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-27  1:55 GDB Administrator
2011-04-27  3:16 ` Yao Qi
2011-04-27 14:53   ` Tom Tromey
2011-04-27 15:08   ` Joel Brobecker [this message]
2011-04-27 15:48     ` Yao Qi
2011-04-27 16:18       ` Joel Brobecker
2011-04-27 16:44         ` Mark Kettenis
2011-04-27 16:59           ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110427150815.GB2489@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox