From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com
Cc: yao@codesourcery.com, gdb-patches@sourceware.org
Subject: Re: New ARI warning Wed Apr 27 01:54:55 UTC 2011
Date: Wed, 27 Apr 2011 16:44:00 -0000 [thread overview]
Message-ID: <201104271642.p3RGgUW8025117@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <20110427161802.GC2489@adacore.com> (message from Joel Brobecker on Wed, 27 Apr 2011 09:18:02 -0700)
> X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00
> X-Spam-Check-By: sourceware.org
> Date: Wed, 27 Apr 2011 09:18:02 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
> Content-Disposition: inline
> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
> Sender: gdb-patches-owner@sourceware.org
> X-XS4ALL-DNSBL-Checked: mxdrop220.xs4all.nl checked 209.132.180.131 against DNS blacklists
> X-CNFS-Analysis: v=1.1 cv=a8sYchbnJd2dMYUqqjolUMD0rF/qLqJCTuzWyWz0xZo= c=1
> sm=0 a=XYJHFtupD_QA:10 a=msjzrvmC9sEA:10 a=idPYu1UqwmkA:10
> a=wPDyFdB5xvgA:10 a=kj9zAlcOel0A:10 a=vbYRN7G9ZuyAWxq09MFwFw==:17
> a=s8b-tOObir8ccsWKurEA:9 a=CjuIK1q_8ugA:10
> a=vbYRN7G9ZuyAWxq09MFwFw==:117
> X-Virus-Scanned: by XS4ALL Virus Scanner
> X-XS4ALL-Spam-Score: -0.0 () SPF_HELO_PASS, SPF_PASS
> X-XS4ALL-Spam: NO
> Envelope-To: m.m.kettenis@xs4all.nl
>
> > Yes, I agree. So far, gdb code is using gdb_wait.h and gdbserver is
> > using sys/wait.h. gdb_wait.h looks quite independent of gdb or
> > gdbserver. Is there any known reason that we can't use gdb_wait.h in
> > gdbserver? I don't see any.
>
> You need to make sure that both configures test for sys/wait.h and
> wait.h. I looked at gdbserver's configure, and it is missing the check
> for wait.
And suddenly even that "trivial" linux-ptrace.h diff is turning into a
can of worms. Some people, including me, have stated that the stuff in
common/ should *not* depend on any configure checks
In this case there probably is a way out though. I don't think there
are any systems out there that don't have <sys/wait.h>. So we could
just get rid of gdb_wait.h altogether.
But this doesn't encourage me to give my blessing to the i386-dbg diff...
next prev parent reply other threads:[~2011-04-27 16:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 1:55 GDB Administrator
2011-04-27 3:16 ` Yao Qi
2011-04-27 14:53 ` Tom Tromey
2011-04-27 15:08 ` Joel Brobecker
2011-04-27 15:48 ` Yao Qi
2011-04-27 16:18 ` Joel Brobecker
2011-04-27 16:44 ` Mark Kettenis [this message]
2011-04-27 16:59 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104271642.p3RGgUW8025117@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox