From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31320 invoked by alias); 27 Apr 2011 03:16:24 -0000 Received: (qmail 31311 invoked by uid 22791); 27 Apr 2011 03:16:24 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 27 Apr 2011 03:16:10 +0000 Received: (qmail 10013 invoked from network); 27 Apr 2011 03:16:09 -0000 Received: from unknown (HELO ?192.168.0.102?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 27 Apr 2011 03:16:09 -0000 Message-ID: <4DB78A74.9060105@codesourcery.com> Date: Wed, 27 Apr 2011 03:16:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.14) Gecko/20110223 Lightning/1.0b2 Thunderbird/3.1.8 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: New ARI warning Wed Apr 27 01:54:55 UTC 2011 References: <20110427015455.GA24839@sourceware.org> In-Reply-To: <20110427015455.GA24839@sourceware.org> Content-Type: multipart/mixed; boundary="------------070102040202090106070006" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00495.txt.bz2 This is a multi-part message in MIME format. --------------070102040202090106070006 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-length: 679 On 04/27/2011 09:54 AM, GDB Administrator wrote: > 119a120 >> gdb/common/linux-ptrace.h:22: regression: wait.h: Do not include wait.h or sys/wait.h, instead include gdb_wait.h > gdb/common/linux-ptrace.h:22:#include sys/wait.h is included for macro __WALL. However, we can safely remove this include from common/linux-ptrace.h because either sys/wait.h or gdb_wait.h is included before including linux-ptrace.h in linux-nat.c and linux-low.c. In linux-nat.c, gdb_wait.h is included in line 25, and linux-ptrace.h is included in line 33. In linux-low.c, sys/wait.h is included in line 23, and linux-ptrace.h is included in line 27. Is it OK? -- Yao (齐尧) --------------070102040202090106070006 Content-Type: text/x-patch; name="remove_include_sys_wait.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="remove_include_sys_wait.patch" Content-length: 587 2011-04-27 Yao Qi * common/linux-ptrace.h: Remove include . Index: common/linux-ptrace.h =================================================================== RCS file: /cvs/src/src/gdb/common/linux-ptrace.h,v retrieving revision 1.1 diff -u -r1.1 linux-ptrace.h --- common/linux-ptrace.h 26 Apr 2011 15:36:04 -0000 1.1 +++ common/linux-ptrace.h 27 Apr 2011 02:52:53 -0000 @@ -19,7 +19,6 @@ #define COMMON_LINUX_PTRACE_H #include -#include /* __WAIT */ #ifndef PTRACE_GETSIGINFO # define PTRACE_GETSIGINFO 0x4202 --------------070102040202090106070006--