Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Maxim Grigoriev <maxim@tensilica.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [commit] Get rid of build warnings on xtensa-tdep.c
Date: Fri, 11 Mar 2011 04:20:00 -0000	[thread overview]
Message-ID: <4D798969.8070309@tensilica.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

My recent updates made FSF GDB build unhappy, see
New ARI warning Fri Mar 11 01:54:56 UTC 2011.
This updates removes inline attributes from the code.



[-- Attachment #2: IW.diff --]
[-- Type: text/plain, Size: 2173 bytes --]

2011-03-10  Maxim Grigoriev  <maxim2405@gmail.com>

	* xtensa-tdep.c (windowing_enabled): Remove inline attribute.
	(xtensa_write_register, xtensa_read_register): Likewise.
	(xtensa_hextochar): Removed.
	(xtensa_init_reggroups): Replace xtensa_hextochar () by explicit code.

Index: gdb/xtensa-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/xtensa-tdep.c,v
retrieving revision 1.53
diff -u -r1.53 xtensa-tdep.c
--- gdb/xtensa-tdep.c	11 Mar 2011 00:21:42 -0000	1.53
+++ gdb/xtensa-tdep.c	11 Mar 2011 02:23:03 -0000
@@ -121,7 +121,7 @@
 #define PS_WOE			(1<<18)
 #define PS_EXC			(1<<4)
 
-static inline int
+static int
 windowing_enabled (struct gdbarch *gdbarch, unsigned int ps)
 {
   /* If we know CALL0 ABI is set explicitly,  say it is Call0.  */
@@ -162,7 +162,7 @@
 }
 
 /* Read Xtensa register directly from the hardware.  */ 
-static inline unsigned long
+static unsigned long
 xtensa_read_register (int regnum)
 {
   ULONGEST value;
@@ -172,7 +172,7 @@
 }
 
 /* Write Xtensa register directly to the hardware.  */ 
-static inline void
+static void
 xtensa_write_register (int regnum, ULONGEST value)
 {
   regcache_raw_write_unsigned (get_current_regcache (), regnum, value);
@@ -734,15 +734,6 @@
 		    _("invalid register number %d"), regnum);
 }
 
-/* Return a character representation of a hex-decimal digit.
-   The value of "xdigit" is assumed to be in a range [0..15].  */
-
-static inline
-char xtensa_hextochar (int xdigit)
-{
-  return '0' + xdigit;
-}
-
 static struct reggroup *xtensa_ar_reggroup;
 static struct reggroup *xtensa_user_reggroup;
 static struct reggroup *xtensa_vectra_reggroup;
@@ -760,7 +751,7 @@
 
   for (i = 0; i < XTENSA_MAX_COPROCESSOR; i++)
     {
-      cpname[2] = xtensa_hextochar (i);
+      cpname[2] = '0' + i;
       xtensa_cp[i] = reggroup_new (cpname, USER_REGGROUP);
     }
 }
@@ -1430,7 +1421,7 @@
 /* Report a problem with prologue analysis while doing backtracing.
    But, do it only once to avoid annoyng repeated messages.  */
 
-static inline void warning_once ()
+static void warning_once ()
 {
   if (xtensa_session_once_reported == 0)
     warning (_("\

             reply	other threads:[~2011-03-11  2:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-11  4:20 Maxim Grigoriev [this message]
2011-03-11  7:59 ` Joel Brobecker
2011-03-11 11:39   ` [RFA] New rules for ARI (was [commit] Get rid of build warnings on xtensa-tdep.c) Pierre Muller
2011-03-11 14:21     ` Joel Brobecker
2011-03-11 14:51       ` Pierre Muller
     [not found]   ` <41860.1858466447$1299837420@news.gmane.org>
2011-03-11 17:07     ` [RFA] New rules for ARI Tom Tromey
2011-03-16 14:23       ` Joel Brobecker
2011-03-16 14:41         ` Pedro Alves
2011-03-16 15:25           ` Tom Tromey
2011-03-16 15:54             ` Pedro Alves
2011-03-16 16:03               ` Tom Tromey
2011-03-16 16:14                 ` Pedro Alves
2011-03-16 17:11                   ` Tom Tromey
2011-03-16 17:11                     ` Pedro Alves
2011-03-16 17:27                       ` Tom Tromey
2011-03-16 17:42                         ` Pedro Alves
2011-03-16 15:18         ` Tom Tromey
2011-03-11 21:04   ` [commit] Correct style issues in xtensa-tdep.c Maxim Grigoriev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D798969.8070309@tensilica.com \
    --to=maxim@tensilica.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox