From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20507 invoked by alias); 11 Mar 2011 02:31:31 -0000 Received: (qmail 20497 invoked by uid 22791); 11 Mar 2011 02:31:30 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_00,SARE_SUB_GETRID,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mailgw.tensilica.com (HELO mailgw.tensilica.com) (65.119.96.134) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Mar 2011 02:31:23 +0000 Received: from localhost (unknown [127.0.0.1]) by mailgw.tensilica.com (Postfix) with ESMTP id 557261160670 for ; Fri, 11 Mar 2011 02:31:22 +0000 (UTC) Received: from mailgw.tensilica.com ([127.0.0.1]) by localhost (mailgw.tensilica.com [127.0.0.1]) (amavisd-maia, port 10024) with ESMTP id 24663-08 for ; Thu, 10 Mar 2011 18:31:22 -0800 (PST) Received: from mail.tensilica.com (mail.tensilica.com [192.168.15.138]) by mailgw.tensilica.com (Postfix) with ESMTP id 27920116066F for ; Thu, 10 Mar 2011 18:31:05 -0800 (PST) Received: from [192.168.11.68] (192.168.11.68) by mail.tensilica.com (192.168.15.138) with Microsoft SMTP Server id 8.2.254.0; Thu, 10 Mar 2011 18:31:06 -0800 Message-ID: <4D798969.8070309@tensilica.com> Date: Fri, 11 Mar 2011 04:20:00 -0000 From: Maxim Grigoriev User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.10 MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: [commit] Get rid of build warnings on xtensa-tdep.c Content-Type: multipart/mixed; boundary="------------010002020001000906090705" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00647.txt.bz2 --------------010002020001000906090705 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Content-length: 152 My recent updates made FSF GDB build unhappy, see New ARI warning Fri Mar 11 01:54:56 UTC 2011. This updates removes inline attributes from the code. --------------010002020001000906090705 Content-Type: text/plain; name="IW.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="IW.diff" Content-length: 2173 2011-03-10 Maxim Grigoriev * xtensa-tdep.c (windowing_enabled): Remove inline attribute. (xtensa_write_register, xtensa_read_register): Likewise. (xtensa_hextochar): Removed. (xtensa_init_reggroups): Replace xtensa_hextochar () by explicit code. Index: gdb/xtensa-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/xtensa-tdep.c,v retrieving revision 1.53 diff -u -r1.53 xtensa-tdep.c --- gdb/xtensa-tdep.c 11 Mar 2011 00:21:42 -0000 1.53 +++ gdb/xtensa-tdep.c 11 Mar 2011 02:23:03 -0000 @@ -121,7 +121,7 @@ #define PS_WOE (1<<18) #define PS_EXC (1<<4) -static inline int +static int windowing_enabled (struct gdbarch *gdbarch, unsigned int ps) { /* If we know CALL0 ABI is set explicitly, say it is Call0. */ @@ -162,7 +162,7 @@ } /* Read Xtensa register directly from the hardware. */ -static inline unsigned long +static unsigned long xtensa_read_register (int regnum) { ULONGEST value; @@ -172,7 +172,7 @@ } /* Write Xtensa register directly to the hardware. */ -static inline void +static void xtensa_write_register (int regnum, ULONGEST value) { regcache_raw_write_unsigned (get_current_regcache (), regnum, value); @@ -734,15 +734,6 @@ _("invalid register number %d"), regnum); } -/* Return a character representation of a hex-decimal digit. - The value of "xdigit" is assumed to be in a range [0..15]. */ - -static inline -char xtensa_hextochar (int xdigit) -{ - return '0' + xdigit; -} - static struct reggroup *xtensa_ar_reggroup; static struct reggroup *xtensa_user_reggroup; static struct reggroup *xtensa_vectra_reggroup; @@ -760,7 +751,7 @@ for (i = 0; i < XTENSA_MAX_COPROCESSOR; i++) { - cpname[2] = xtensa_hextochar (i); + cpname[2] = '0' + i; xtensa_cp[i] = reggroup_new (cpname, USER_REGGROUP); } } @@ -1430,7 +1421,7 @@ /* Report a problem with prologue analysis while doing backtracing. But, do it only once to avoid annoyng repeated messages. */ -static inline void warning_once () +static void warning_once () { if (xtensa_session_once_reported == 0) warning (_("\ --------------010002020001000906090705--