From: Joel Brobecker <brobecker@adacore.com>
To: Maxim Grigoriev <maxim@tensilica.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [commit] Get rid of build warnings on xtensa-tdep.c
Date: Fri, 11 Mar 2011 07:59:00 -0000 [thread overview]
Message-ID: <20110311064501.GA30306@adacore.com> (raw)
In-Reply-To: <4D798969.8070309@tensilica.com>
> 2011-03-10 Maxim Grigoriev <maxim2405@gmail.com>
>
> * xtensa-tdep.c (windowing_enabled): Remove inline attribute.
> (xtensa_write_register, xtensa_read_register): Likewise.
> (xtensa_hextochar): Removed.
> (xtensa_init_reggroups): Replace xtensa_hextochar () by explicit code.
Small comments, seen while scanning your patch...
> -static inline void warning_once ()
> +static void warning_once ()
The function name should be on the first column of the line.
This is to facilitate the search of the function implementation
(we can use: <<grep "^warning_once">> for instance). Also,
functions with no arguments should be declared with a "void"
parameter. Thus:
static void
warning_once (void)
--
Joel
next prev parent reply other threads:[~2011-03-11 6:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 4:20 Maxim Grigoriev
2011-03-11 7:59 ` Joel Brobecker [this message]
2011-03-11 11:39 ` [RFA] New rules for ARI (was [commit] Get rid of build warnings on xtensa-tdep.c) Pierre Muller
2011-03-11 14:21 ` Joel Brobecker
2011-03-11 14:51 ` Pierre Muller
[not found] ` <41860.1858466447$1299837420@news.gmane.org>
2011-03-11 17:07 ` [RFA] New rules for ARI Tom Tromey
2011-03-16 14:23 ` Joel Brobecker
2011-03-16 14:41 ` Pedro Alves
2011-03-16 15:25 ` Tom Tromey
2011-03-16 15:54 ` Pedro Alves
2011-03-16 16:03 ` Tom Tromey
2011-03-16 16:14 ` Pedro Alves
2011-03-16 17:11 ` Tom Tromey
2011-03-16 17:11 ` Pedro Alves
2011-03-16 17:27 ` Tom Tromey
2011-03-16 17:42 ` Pedro Alves
2011-03-16 15:18 ` Tom Tromey
2011-03-11 21:04 ` [commit] Correct style issues in xtensa-tdep.c Maxim Grigoriev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110311064501.GA30306@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=maxim@tensilica.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox