From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23168 invoked by alias); 11 Mar 2011 06:45:17 -0000 Received: (qmail 23160 invoked by uid 22791); 11 Mar 2011 06:45:17 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_SUB_GETRID X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Mar 2011 06:45:11 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5F2A22BB13B; Fri, 11 Mar 2011 01:45:10 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id eN1s7sH6PJUf; Fri, 11 Mar 2011 01:45:10 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9CC512BB139; Fri, 11 Mar 2011 01:45:09 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id CD3A61459AD; Fri, 11 Mar 2011 10:45:01 +0400 (RET) Date: Fri, 11 Mar 2011 07:59:00 -0000 From: Joel Brobecker To: Maxim Grigoriev Cc: "gdb-patches@sourceware.org" Subject: Re: [commit] Get rid of build warnings on xtensa-tdep.c Message-ID: <20110311064501.GA30306@adacore.com> References: <4D798969.8070309@tensilica.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D798969.8070309@tensilica.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00653.txt.bz2 > 2011-03-10 Maxim Grigoriev > > * xtensa-tdep.c (windowing_enabled): Remove inline attribute. > (xtensa_write_register, xtensa_read_register): Likewise. > (xtensa_hextochar): Removed. > (xtensa_init_reggroups): Replace xtensa_hextochar () by explicit code. Small comments, seen while scanning your patch... > -static inline void warning_once () > +static void warning_once () The function name should be on the first column of the line. This is to facilitate the search of the function implementation (we can use: <> for instance). Also, functions with no arguments should be declared with a "void" parameter. Thus: static void warning_once (void) -- Joel