Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: 'Maxim Grigoriev' <maxim@tensilica.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] New rules for ARI (was  [commit] Get rid of build warnings on xtensa-tdep.c)
Date: Fri, 11 Mar 2011 14:21:00 -0000	[thread overview]
Message-ID: <20110311114012.GE30306@adacore.com> (raw)
In-Reply-To: <001e01cbdfd2$96205a60$c2610f20$@muller@ics-cnrs.unistra.fr>

> so I tried to write a new rule
> to find out if functions that have no parameters
> do use () instead of (void).

Thanks!

>   While at it, I also tried to figure out if
> there were calls to functions in first lines
> (or prototype declarations with the function name at first line).

I think you meant first column?

> OK to add these two new rules?

I think they would be useful - but be sure to s/line/column/ in
the code as well:

> +# Only function implementation should be on first line
> +BEGIN { doc["function call in first line"] = "\
> +Function name in first line should be restricted to function
> implementation"
> +    category["function call in first line"] = ari_code
> +}
> +/^[a-z][a-z0-9_]*[[:space:]]*\((|[^*][^()]*)\)[[:space:]]*[^ \t]+/ {
> +    fail("function call in first line")
> +}

-- 
Joel


  reply	other threads:[~2011-03-11 11:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-11  4:20 [commit] Get rid of build warnings on xtensa-tdep.c Maxim Grigoriev
2011-03-11  7:59 ` Joel Brobecker
2011-03-11 11:39   ` [RFA] New rules for ARI (was [commit] Get rid of build warnings on xtensa-tdep.c) Pierre Muller
2011-03-11 14:21     ` Joel Brobecker [this message]
2011-03-11 14:51       ` Pierre Muller
     [not found]   ` <41860.1858466447$1299837420@news.gmane.org>
2011-03-11 17:07     ` [RFA] New rules for ARI Tom Tromey
2011-03-16 14:23       ` Joel Brobecker
2011-03-16 14:41         ` Pedro Alves
2011-03-16 15:25           ` Tom Tromey
2011-03-16 15:54             ` Pedro Alves
2011-03-16 16:03               ` Tom Tromey
2011-03-16 16:14                 ` Pedro Alves
2011-03-16 17:11                   ` Tom Tromey
2011-03-16 17:11                     ` Pedro Alves
2011-03-16 17:27                       ` Tom Tromey
2011-03-16 17:42                         ` Pedro Alves
2011-03-16 15:18         ` Tom Tromey
2011-03-11 21:04   ` [commit] Correct style issues in xtensa-tdep.c Maxim Grigoriev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110311114012.GE30306@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=maxim@tensilica.com \
    --cc=pierre.muller@ics-cnrs.unistra.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox