From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,
"'Maxim Grigoriev'" <maxim@tensilica.com>,
gdb-patches@sourceware.org
Subject: Re: [RFA] New rules for ARI
Date: Wed, 16 Mar 2011 15:18:00 -0000 [thread overview]
Message-ID: <m3tyf35cse.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20110316140240.GQ31264@adacore.com> (Joel Brobecker's message of "Wed, 16 Mar 2011 07:02:40 -0700")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> Actually, it would. But when I tried to use it in our build,
Joel> I quickly hit a problem, because the headers we include might not
Joel> have strict prototypes. For instance, readline defines:
Joel> typedef int Function ();
Joel> typedef void VFunction ();
Joel> typedef char *CPFunction ();
Joel> typedef char **CPPFunction ();
Joel> So, unless there is a way to say check strict-prototyping certain
Joel> files only, it's going to be tough to use :-(.
We can work around that by defining _FUNCTION_DEF and also including
readline/config.h. But, it is a mess :-(. For one thing, the new
standalone readline doesn't seem to install readline/config.h, and
nothing else defines PREFER_STDARG, so the distro case would be broken.
I did this as a hack though and it worked ok-ish in tree. It found some
mildly questionable TUI code and also a few more minor cases that I will
fix.
Tom
next prev parent reply other threads:[~2011-03-16 15:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 4:20 [commit] Get rid of build warnings on xtensa-tdep.c Maxim Grigoriev
2011-03-11 7:59 ` Joel Brobecker
2011-03-11 11:39 ` [RFA] New rules for ARI (was [commit] Get rid of build warnings on xtensa-tdep.c) Pierre Muller
2011-03-11 14:21 ` Joel Brobecker
2011-03-11 14:51 ` Pierre Muller
[not found] ` <41860.1858466447$1299837420@news.gmane.org>
2011-03-11 17:07 ` [RFA] New rules for ARI Tom Tromey
2011-03-16 14:23 ` Joel Brobecker
2011-03-16 14:41 ` Pedro Alves
2011-03-16 15:25 ` Tom Tromey
2011-03-16 15:54 ` Pedro Alves
2011-03-16 16:03 ` Tom Tromey
2011-03-16 16:14 ` Pedro Alves
2011-03-16 17:11 ` Tom Tromey
2011-03-16 17:11 ` Pedro Alves
2011-03-16 17:27 ` Tom Tromey
2011-03-16 17:42 ` Pedro Alves
2011-03-16 15:18 ` Tom Tromey [this message]
2011-03-11 21:04 ` [commit] Correct style issues in xtensa-tdep.c Maxim Grigoriev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3tyf35cse.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=maxim@tensilica.com \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox