* [RFA] bfd, elf64-x86-64.c (elf_x86_64_relocate_section): document fall through.
@ 2011-03-06 1:09 Michael Snyder
2011-03-06 1:37 ` H.J. Lu
0 siblings, 1 reply; 3+ messages in thread
From: Michael Snyder @ 2011-03-06 1:09 UTC (permalink / raw)
To: gdb-patches, binutils, H.J. Lu
[-- Attachment #1: Type: text/plain, Size: 50 bytes --]
Assuming that it was meant to fall through.
OK?
[-- Attachment #2: elf64-x86-64b.txt --]
[-- Type: text/plain, Size: 682 bytes --]
2011-03-05 Michael Snyder <msnyder@vmware.com>
* elf64-x86-64.c (elf_x86_64_relocate_section): Document
that case statement falls through intentionally.
Index: elf64-x86-64.c
===================================================================
RCS file: /cvs/src/src/bfd/elf64-x86-64.c,v
retrieving revision 1.214
diff -u -p -r1.214 elf64-x86-64.c
--- elf64-x86-64.c 4 Mar 2011 00:38:29 -0000 1.214
+++ elf64-x86-64.c 6 Mar 2011 01:02:50 -0000
@@ -2887,6 +2887,7 @@ elf_x86_64_relocate_section (bfd *output
case R_X86_64_32:
if (ABI_64_P (output_bfd))
goto do_relocation;
+ /* FALLTHROUGH */
case R_X86_64_64:
if (rel->r_addend != 0)
{
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RFA] bfd, elf64-x86-64.c (elf_x86_64_relocate_section): document fall through.
2011-03-06 1:09 [RFA] bfd, elf64-x86-64.c (elf_x86_64_relocate_section): document fall through Michael Snyder
@ 2011-03-06 1:37 ` H.J. Lu
2011-03-06 18:42 ` Michael Snyder
0 siblings, 1 reply; 3+ messages in thread
From: H.J. Lu @ 2011-03-06 1:37 UTC (permalink / raw)
To: Michael Snyder; +Cc: gdb-patches, binutils
On Sat, Mar 5, 2011 at 5:09 PM, Michael Snyder <msnyder@vmware.com> wrote:
> Assuming that it was meant to fall through.
>
> OK?
>
>
> 2011-03-05 Michael Snyder <msnyder@vmware.com>
>
> * elf64-x86-64.c (elf_x86_64_relocate_section): Document
> that case statement falls through intentionally.
>
> Index: elf64-x86-64.c
> ===================================================================
> RCS file: /cvs/src/src/bfd/elf64-x86-64.c,v
> retrieving revision 1.214
> diff -u -p -r1.214 elf64-x86-64.c
> --- elf64-x86-64.c 4 Mar 2011 00:38:29 -0000 1.214
> +++ elf64-x86-64.c 6 Mar 2011 01:02:50 -0000
> @@ -2887,6 +2887,7 @@ elf_x86_64_relocate_section (bfd *output
> case R_X86_64_32:
> if (ABI_64_P (output_bfd))
> goto do_relocation;
> + /* FALLTHROUGH */
> case R_X86_64_64:
> if (rel->r_addend != 0)
> {
>
OK. Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RFA] bfd, elf64-x86-64.c (elf_x86_64_relocate_section): document fall through.
2011-03-06 1:37 ` H.J. Lu
@ 2011-03-06 18:42 ` Michael Snyder
0 siblings, 0 replies; 3+ messages in thread
From: Michael Snyder @ 2011-03-06 18:42 UTC (permalink / raw)
To: H.J. Lu; +Cc: gdb-patches, binutils
H.J. Lu wrote:
> On Sat, Mar 5, 2011 at 5:09 PM, Michael Snyder <msnyder@vmware.com> wrote:
>> Assuming that it was meant to fall through.
>>
>> OK?
>>
>>
>> 2011-03-05 Michael Snyder <msnyder@vmware.com>
>>
>> * elf64-x86-64.c (elf_x86_64_relocate_section): Document
>> that case statement falls through intentionally.
>>
>> Index: elf64-x86-64.c
>> ===================================================================
>> RCS file: /cvs/src/src/bfd/elf64-x86-64.c,v
>> retrieving revision 1.214
>> diff -u -p -r1.214 elf64-x86-64.c
>> --- elf64-x86-64.c 4 Mar 2011 00:38:29 -0000 1.214
>> +++ elf64-x86-64.c 6 Mar 2011 01:02:50 -0000
>> @@ -2887,6 +2887,7 @@ elf_x86_64_relocate_section (bfd *output
>> case R_X86_64_32:
>> if (ABI_64_P (output_bfd))
>> goto do_relocation;
>> + /* FALLTHROUGH */
>> case R_X86_64_64:
>> if (rel->r_addend != 0)
>> {
>>
>
>
> OK. Thanks.
Committed.
Thanks for the review.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-06 18:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-06 1:09 [RFA] bfd, elf64-x86-64.c (elf_x86_64_relocate_section): document fall through Michael Snyder
2011-03-06 1:37 ` H.J. Lu
2011-03-06 18:42 ` Michael Snyder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox