From: Michael Snyder <msnyder@vmware.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: [RFA] bfd, elf64-x86-64.c (elf_x86_64_relocate_section): document fall through.
Date: Sun, 06 Mar 2011 18:42:00 -0000 [thread overview]
Message-ID: <4D73D238.7010201@vmware.com> (raw)
In-Reply-To: <AANLkTik_nYNo1U4nWbCTTUXsh0_yuEmqTpuG0rmDwZ7j@mail.gmail.com>
H.J. Lu wrote:
> On Sat, Mar 5, 2011 at 5:09 PM, Michael Snyder <msnyder@vmware.com> wrote:
>> Assuming that it was meant to fall through.
>>
>> OK?
>>
>>
>> 2011-03-05 Michael Snyder <msnyder@vmware.com>
>>
>> * elf64-x86-64.c (elf_x86_64_relocate_section): Document
>> that case statement falls through intentionally.
>>
>> Index: elf64-x86-64.c
>> ===================================================================
>> RCS file: /cvs/src/src/bfd/elf64-x86-64.c,v
>> retrieving revision 1.214
>> diff -u -p -r1.214 elf64-x86-64.c
>> --- elf64-x86-64.c 4 Mar 2011 00:38:29 -0000 1.214
>> +++ elf64-x86-64.c 6 Mar 2011 01:02:50 -0000
>> @@ -2887,6 +2887,7 @@ elf_x86_64_relocate_section (bfd *output
>> case R_X86_64_32:
>> if (ABI_64_P (output_bfd))
>> goto do_relocation;
>> + /* FALLTHROUGH */
>> case R_X86_64_64:
>> if (rel->r_addend != 0)
>> {
>>
>
>
> OK. Thanks.
Committed.
Thanks for the review.
prev parent reply other threads:[~2011-03-06 18:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-06 1:09 Michael Snyder
2011-03-06 1:37 ` H.J. Lu
2011-03-06 18:42 ` Michael Snyder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D73D238.7010201@vmware.com \
--to=msnyder@vmware.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox