From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12960 invoked by alias); 6 Mar 2011 01:09:57 -0000 Received: (qmail 12947 invoked by uid 22791); 6 Mar 2011 01:09:57 -0000 X-SWARE-Spam-Status: No, hits=-5.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 06 Mar 2011 01:09:53 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 028AA1F000; Sat, 5 Mar 2011 17:09:52 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost2.vmware.com (Postfix) with ESMTP id 63E6A8EC3C; Sat, 5 Mar 2011 17:09:51 -0800 (PST) Message-ID: <4D72DEDF.8010307@vmware.com> Date: Sun, 06 Mar 2011 01:09:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" , binutils@sourceware.org, "H.J. Lu" Subject: [RFA] bfd, elf64-x86-64.c (elf_x86_64_relocate_section): document fall through. Content-Type: multipart/mixed; boundary="------------040600050601080401080504" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00380.txt.bz2 This is a multi-part message in MIME format. --------------040600050601080401080504 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 50 Assuming that it was meant to fall through. OK? --------------040600050601080401080504 Content-Type: text/plain; name="elf64-x86-64b.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="elf64-x86-64b.txt" Content-length: 682 2011-03-05 Michael Snyder * elf64-x86-64.c (elf_x86_64_relocate_section): Document that case statement falls through intentionally. Index: elf64-x86-64.c =================================================================== RCS file: /cvs/src/src/bfd/elf64-x86-64.c,v retrieving revision 1.214 diff -u -p -r1.214 elf64-x86-64.c --- elf64-x86-64.c 4 Mar 2011 00:38:29 -0000 1.214 +++ elf64-x86-64.c 6 Mar 2011 01:02:50 -0000 @@ -2887,6 +2887,7 @@ elf_x86_64_relocate_section (bfd *output case R_X86_64_32: if (ABI_64_P (output_bfd)) goto do_relocation; + /* FALLTHROUGH */ case R_X86_64_64: if (rel->r_addend != 0) { --------------040600050601080401080504--