From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79270-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7618 invoked by alias); 6 Mar 2011 01:37:55 -0000
Received: (qmail 7597 invoked by uid 22791); 6 Mar 2011 01:37:54 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from mail-iy0-f169.google.com (HELO mail-iy0-f169.google.com) (209.85.210.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 06 Mar 2011 01:37:50 +0000
Received: by mail-iy0-f169.google.com with SMTP id 13so4056002iyf.0        for <multiple recipients>; Sat, 05 Mar 2011 17:37:50 -0800 (PST)
MIME-Version: 1.0
Received: by 10.42.244.10 with SMTP id lo10mr685873icb.513.1299375469896; Sat, 05 Mar 2011 17:37:49 -0800 (PST)
Received: by 10.42.60.129 with HTTP; Sat, 5 Mar 2011 17:37:49 -0800 (PST)
In-Reply-To: <4D72DEDF.8010307@vmware.com>
References: <4D72DEDF.8010307@vmware.com>
Date: Sun, 06 Mar 2011 01:37:00 -0000
Message-ID: <AANLkTik_nYNo1U4nWbCTTUXsh0_yuEmqTpuG0rmDwZ7j@mail.gmail.com>
Subject: Re: [RFA] bfd, elf64-x86-64.c (elf_x86_64_relocate_section): document fall through.
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, binutils@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00383.txt.bz2

On Sat, Mar 5, 2011 at 5:09 PM, Michael Snyder <msnyder@vmware.com> wrote:
> Assuming that it was meant to fall through.
>
> OK?
>
>
> 2011-03-05 =A0Michael Snyder =A0<msnyder@vmware.com>
>
> =A0 =A0 =A0 =A0* elf64-x86-64.c (elf_x86_64_relocate_section): Document
> =A0 =A0 =A0 =A0that case statement falls through intentionally.
>
> Index: elf64-x86-64.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvs/src/src/bfd/elf64-x86-64.c,v
> retrieving revision 1.214
> diff -u -p -r1.214 elf64-x86-64.c
> --- elf64-x86-64.c =A0 =A0 =A04 Mar 2011 00:38:29 -0000 =A0 =A0 =A0 1.214
> +++ elf64-x86-64.c =A0 =A0 =A06 Mar 2011 01:02:50 -0000
> @@ -2887,6 +2887,7 @@ elf_x86_64_relocate_section (bfd *output
> =A0 =A0 =A0 =A0 =A0 =A0case R_X86_64_32:
> =A0 =A0 =A0 =A0 =A0 =A0 =A0if (ABI_64_P (output_bfd))
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0goto do_relocation;
> + =A0 =A0 =A0 =A0 =A0 =A0 /* FALLTHROUGH */
> =A0 =A0 =A0 =A0 =A0 =A0case R_X86_64_64:
> =A0 =A0 =A0 =A0 =A0 =A0 =A0if (rel->r_addend !=3D 0)
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0{
>


OK.  Thanks.



--=20
H.J.