Re: [rfa] remote-fileio.c, remote_fileio_func_fstat, uninitialized st.st_ino.

[Michael Snyder <msnyder@vmware.com>]

Corinna Vinschen wrote:
> On Mar  3 09:21, Michael Snyder wrote:
>> Corinna Vinschen wrote:
>>> On Mar  3 10:04, Pedro Alves wrote:
>>>> Can't we just memset `st' instead?
>>> That would be the simplest solution.  Afterwards, just set the
>>> non-zero fields.
>> OK, how about this?
>>
> 
>> 2011-03-03  Michael Snyder  <...>
>>
>> 	* remote-fileio.c (remote_fileio_func_fstat): Initialize all
>> 	fields of struct 'st' to zero.
>>
>> Index: remote-fileio.c
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/remote-fileio.c,v
>> retrieving revision 1.40
>> diff -u -p -u -p -r1.40 remote-fileio.c
>> --- remote-fileio.c	25 Jan 2011 11:54:00 -0000	1.40
>> +++ remote-fileio.c	3 Mar 2011 17:20:06 -0000
>> @@ -1173,20 +1173,15 @@ remote_fileio_func_fstat (char *buf)
>>    if (fd == FIO_FD_CONSOLE_IN || fd == FIO_FD_CONSOLE_OUT)
>>      {
>>        remote_fileio_to_fio_uint (1, fst.fst_dev);
>> +      memset (&st, 0, sizeof (st));
>>        st.st_mode = S_IFCHR | (fd == FIO_FD_CONSOLE_IN ? S_IRUSR : S_IWUSR);
>>        st.st_nlink = 1;
>>  #ifdef HAVE_GETUID
>>        st.st_uid = getuid ();
>> -#else
>> -      st.st_uid = 0;
>>  #endif
>>  #ifdef HAVE_GETGID
>>        st.st_gid = getgid ();
>> -#else
>> -      st.st_gid = 0;
>>  #endif
>> -      st.st_rdev = 0;
>> -      st.st_size = 0;
>>  #ifdef HAVE_STRUCT_STAT_ST_BLKSIZE
>>        st.st_blksize = 512;
>>  #endif
> 
> Perfect.
> 
> Thanks,
> Corinna
> 

Committed.
Thanks,
Michael