From: Corinna Vinschen <vinschen@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [rfa] remote-fileio.c, remote_fileio_func_fstat, uninitialized st.st_ino.
Date: Thu, 03 Mar 2011 08:29:00 -0000 [thread overview]
Message-ID: <20110303082857.GA10587@calimero.vinschen.de> (raw)
In-Reply-To: <20110303043643.GV30306@adacore.com>
On Mar 3 08:36, Joel Brobecker wrote:
> > 2011-03-02 Michael Snyder <...>
> >
> > * remote-fileio.c (remote_fileio_func_fstat): Initialize st_ino
> > to zero.
>
> FWIW: The initialization is made for the case where the file descriptor
> is not a file, so we should be ablet to deduce that the st_ino (inode ID)
> is irrelevant and not used on the consumer side... This would suggest
> that your change is correct. (you should still wait for Corinna to
> comment)
The descriptors are console descriptors so the inode number doesn't
matter and the patch is ok.
I'm just wondering, can we assume that the stat structure has always an
st_ino member? THere are checks for st_blocks and st_blksize in place
already. Is the same required for st_ino?
Corinna
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat
next prev parent reply other threads:[~2011-03-03 8:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 21:49 Michael Snyder
2011-03-03 4:37 ` Joel Brobecker
2011-03-03 8:29 ` Corinna Vinschen [this message]
2011-03-03 9:25 ` Joel Brobecker
2011-03-03 10:04 ` Pedro Alves
2011-03-03 10:51 ` Corinna Vinschen
2011-03-03 17:22 ` Michael Snyder
2011-03-03 17:35 ` Corinna Vinschen
2011-03-03 18:36 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110303082857.GA10587@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox