From: Michael Snyder <msnyder@vmware.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: vinschen@redhat.com
Subject: [rfa] remote-fileio.c, remote_fileio_func_fstat, uninitialized st.st_ino.
Date: Wed, 02 Mar 2011 21:49:00 -0000 [thread overview]
Message-ID: <4D6EBB4A.9080207@vmware.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 236 bytes --]
Hi Corinna,
Coverity points out that st.st_ino is un-initialized when it is passed
to remote_fileio_to_fio_stat, which uses it. I have no idea if
initializing it to zero is the right thing to do. Can you comment?
Thanks,
Michael
[-- Attachment #2: fileio.txt --]
[-- Type: text/plain, Size: 715 bytes --]
2011-03-02 Michael Snyder <msnyder@vmware.com>
* remote-fileio.c (remote_fileio_func_fstat): Initialize st_ino
to zero.
Index: remote-fileio.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-fileio.c,v
retrieving revision 1.40
diff -u -p -u -p -r1.40 remote-fileio.c
--- remote-fileio.c 25 Jan 2011 11:54:00 -0000 1.40
+++ remote-fileio.c 2 Mar 2011 21:41:48 -0000
@@ -1175,6 +1175,7 @@ remote_fileio_func_fstat (char *buf)
remote_fileio_to_fio_uint (1, fst.fst_dev);
st.st_mode = S_IFCHR | (fd == FIO_FD_CONSOLE_IN ? S_IRUSR : S_IWUSR);
st.st_nlink = 1;
+ st.st_ino = 0;
#ifdef HAVE_GETUID
st.st_uid = getuid ();
#else
next reply other threads:[~2011-03-02 21:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 21:49 Michael Snyder [this message]
2011-03-03 4:37 ` Joel Brobecker
2011-03-03 8:29 ` Corinna Vinschen
2011-03-03 9:25 ` Joel Brobecker
2011-03-03 10:04 ` Pedro Alves
2011-03-03 10:51 ` Corinna Vinschen
2011-03-03 17:22 ` Michael Snyder
2011-03-03 17:35 ` Corinna Vinschen
2011-03-03 18:36 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6EBB4A.9080207@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox