From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: Re: [rfa] remote-fileio.c, remote_fileio_func_fstat, uninitialized st.st_ino.
Date: Thu, 03 Mar 2011 09:25:00 -0000 [thread overview]
Message-ID: <20110303092532.GW30306@adacore.com> (raw)
In-Reply-To: <20110303082857.GA10587@calimero.vinschen.de>
> I'm just wondering, can we assume that the stat structure has always an
> st_ino member? THere are checks for st_blocks and st_blksize in place
> already. Is the same required for st_ino?
I think it's fine, at least for now. The good news is that this
field is described in the Open Group's page for this type:
http://pubs.opengroup.org/onlinepubs/009695399/basedefs/sys/stat.h.html
So I think we can count on it (although, I don't know enough about C
to know how much authority this has)
But, regardless, I think we can leave it be until such day where
we actually come across a system where the field actually does not
exist... When that happens, we can easily fix the build failure.
--
Joel
next prev parent reply other threads:[~2011-03-03 9:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 21:49 Michael Snyder
2011-03-03 4:37 ` Joel Brobecker
2011-03-03 8:29 ` Corinna Vinschen
2011-03-03 9:25 ` Joel Brobecker [this message]
2011-03-03 10:04 ` Pedro Alves
2011-03-03 10:51 ` Corinna Vinschen
2011-03-03 17:22 ` Michael Snyder
2011-03-03 17:35 ` Corinna Vinschen
2011-03-03 18:36 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110303092532.GW30306@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox