From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25322 invoked by alias); 3 Mar 2011 08:29:20 -0000 Received: (qmail 25310 invoked by uid 22791); 3 Mar 2011 08:29:09 -0000 X-Spam-Check-By: sourceware.org Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.83/v0.83-20-g38e4449) with ESMTP; Thu, 03 Mar 2011 08:29:00 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id 833882C0282; Thu, 3 Mar 2011 09:28:57 +0100 (CET) Date: Thu, 03 Mar 2011 08:29:00 -0000 From: Corinna Vinschen To: gdb-patches@sourceware.org Subject: Re: [rfa] remote-fileio.c, remote_fileio_func_fstat, uninitialized st.st_ino. Message-ID: <20110303082857.GA10587@calimero.vinschen.de> Reply-To: gdb-patches@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org References: <4D6EBB4A.9080207@vmware.com> <20110303043643.GV30306@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20110303043643.GV30306@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00159.txt.bz2 On Mar 3 08:36, Joel Brobecker wrote: > > 2011-03-02 Michael Snyder <...> > > > > * remote-fileio.c (remote_fileio_func_fstat): Initialize st_ino > > to zero. > > FWIW: The initialization is made for the case where the file descriptor > is not a file, so we should be ablet to deduce that the st_ino (inode ID) > is irrelevant and not used on the consumer side... This would suggest > that your change is correct. (you should still wait for Corinna to > comment) The descriptors are console descriptors so the inode number doesn't matter and the patch is ok. I'm just wondering, can we assume that the stat structure has always an st_ino member? THere are checks for st_blocks and st_blksize in place already. Is the same required for st_ino? Corinna -- Corinna Vinschen Cygwin Project Co-Leader Red Hat