From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22089 invoked by alias); 3 Mar 2011 18:36:07 -0000 Received: (qmail 21978 invoked by uid 22791); 3 Mar 2011 18:36:06 -0000 X-SWARE-Spam-Status: No, hits=-5.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Mar 2011 18:36:02 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 7C5AEA00B for ; Thu, 3 Mar 2011 10:36:01 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost2.vmware.com (Postfix) with ESMTP id 7125B8EE8A for ; Thu, 3 Mar 2011 10:36:01 -0800 (PST) Message-ID: <4D6FDF91.8010101@vmware.com> Date: Thu, 03 Mar 2011 18:36:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [rfa] remote-fileio.c, remote_fileio_func_fstat, uninitialized st.st_ino. References: <4D6EBB4A.9080207@vmware.com> <20110303082857.GA10587@calimero.vinschen.de> <20110303092532.GW30306@adacore.com> <201103031004.02585.pedro@codesourcery.com> <20110303105029.GA22636@calimero.vinschen.de> <4D6FCE37.1090902@vmware.com> <20110303173458.GB16894@calimero.vinschen.de> In-Reply-To: <20110303173458.GB16894@calimero.vinschen.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00200.txt.bz2 Corinna Vinschen wrote: > On Mar 3 09:21, Michael Snyder wrote: >> Corinna Vinschen wrote: >>> On Mar 3 10:04, Pedro Alves wrote: >>>> Can't we just memset `st' instead? >>> That would be the simplest solution. Afterwards, just set the >>> non-zero fields. >> OK, how about this? >> > >> 2011-03-03 Michael Snyder <...> >> >> * remote-fileio.c (remote_fileio_func_fstat): Initialize all >> fields of struct 'st' to zero. >> >> Index: remote-fileio.c >> =================================================================== >> RCS file: /cvs/src/src/gdb/remote-fileio.c,v >> retrieving revision 1.40 >> diff -u -p -u -p -r1.40 remote-fileio.c >> --- remote-fileio.c 25 Jan 2011 11:54:00 -0000 1.40 >> +++ remote-fileio.c 3 Mar 2011 17:20:06 -0000 >> @@ -1173,20 +1173,15 @@ remote_fileio_func_fstat (char *buf) >> if (fd == FIO_FD_CONSOLE_IN || fd == FIO_FD_CONSOLE_OUT) >> { >> remote_fileio_to_fio_uint (1, fst.fst_dev); >> + memset (&st, 0, sizeof (st)); >> st.st_mode = S_IFCHR | (fd == FIO_FD_CONSOLE_IN ? S_IRUSR : S_IWUSR); >> st.st_nlink = 1; >> #ifdef HAVE_GETUID >> st.st_uid = getuid (); >> -#else >> - st.st_uid = 0; >> #endif >> #ifdef HAVE_GETGID >> st.st_gid = getgid (); >> -#else >> - st.st_gid = 0; >> #endif >> - st.st_rdev = 0; >> - st.st_size = 0; >> #ifdef HAVE_STRUCT_STAT_ST_BLKSIZE >> st.st_blksize = 512; >> #endif > > Perfect. > > Thanks, > Corinna > Committed. Thanks, Michael