From: Michael Snyder <msnyder@vmware.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] fix crasher on detach command
Date: Tue, 08 Jun 2010 00:11:00 -0000 [thread overview]
Message-ID: <4C0D8AA7.5090200@vmware.com> (raw)
In-Reply-To: <201006072012.18043.pedro@codesourcery.com>
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
Pedro Alves wrote:
> To be a bit clearer --
>
> you've said that the pid was left as 42000 (I assume you meant
> inferior_ptid, but that find_inferior no longer finds that inferior.
> Where is the current inferior getting it's pid cleared out? Why
> aren't we clearing inferior_ptid as well?
OK, right.
remote_close calls discard_all_inferiors -- it should also
set inferior_ptid to null_ptid at the same time.
How's this patch?
[-- Attachment #2: detach.txt --]
[-- Type: text/plain, Size: 721 bytes --]
2010-06-07 Michael Snyder <msnyder@vmware.com>
* remote.c (remote_close): Set inferior_ptid to null_ptid.
Index: remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.415
diff -u -p -r1.415 remote.c
--- remote.c 2 Jun 2010 22:21:53 -0000 1.415
+++ remote.c 8 Jun 2010 00:08:57 -0000
@@ -2811,6 +2811,7 @@ remote_close (int quitting)
/* We don't have a connection to the remote stub anymore. Get rid
of all the inferiors and their threads we were controlling. */
discard_all_inferiors ();
+ inferior_ptid = null_ptid;
/* We're no longer interested in any of these events. */
discard_pending_stop_replies (-1);
next prev parent reply other threads:[~2010-06-08 0:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 18:11 Michael Snyder
2010-06-07 18:28 ` Pedro Alves
2010-06-07 18:31 ` Michael Snyder
2010-06-07 18:37 ` Pedro Alves
2010-06-07 19:00 ` Michael Snyder
2010-06-07 19:09 ` Pedro Alves
2010-06-07 19:12 ` Pedro Alves
2010-06-07 23:50 ` Michael Snyder
2010-06-08 12:56 ` Pedro Alves
2010-06-08 0:11 ` Michael Snyder [this message]
2010-06-08 12:59 ` Pedro Alves
2010-06-08 16:52 ` Michael Snyder
2010-06-08 2:42 ` Hui Zhu
2010-06-08 12:54 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0D8AA7.5090200@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox