Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@vmware.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [RFA] fix crasher on detach command
Date: Mon, 07 Jun 2010 18:11:00 -0000	[thread overview]
Message-ID: <4C0D3636.8040206@vmware.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

Hi,

The circumstances are, detach from a remote target that doesn't have
threads.  Remote.c leaves the PID arbitrarily as "42000", and
target_detach calls remove_breakpoints_pid, which crashes because
find_inferior_pid returns NULL.

The patch just adds a test for NULL.


[-- Attachment #2: null.txt --]
[-- Type: text/plain, Size: 637 bytes --]

2010-06-07  Michael Snyder  <msnyder@vmware.com>

	* breakpoint.c (remove_breakpoints_pid): Check for null.

Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.488
diff -u -p -r1.488 breakpoint.c
--- breakpoint.c	7 Jun 2010 13:38:25 -0000	1.488
+++ breakpoint.c	7 Jun 2010 18:05:28 -0000
@@ -2041,6 +2041,9 @@ remove_breakpoints_pid (int pid)
   int val;
   struct inferior *inf = find_inferior_pid (pid);
 
+  if (inf == NULL)      /* bail out */
+    return 0;
+
   ALL_BP_LOCATIONS (b, b_tmp)
   {
     if (b->pspace != inf->pspace)

             reply	other threads:[~2010-06-07 18:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-07 18:11 Michael Snyder [this message]
2010-06-07 18:28 ` Pedro Alves
2010-06-07 18:31   ` Michael Snyder
2010-06-07 18:37     ` Pedro Alves
2010-06-07 19:00       ` Michael Snyder
2010-06-07 19:09         ` Pedro Alves
2010-06-07 19:12           ` Pedro Alves
2010-06-07 23:50             ` Michael Snyder
2010-06-08 12:56               ` Pedro Alves
2010-06-08  0:11             ` Michael Snyder
2010-06-08 12:59               ` Pedro Alves
2010-06-08 16:52                 ` Michael Snyder
2010-06-08  2:42   ` Hui Zhu
2010-06-08 12:54     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C0D3636.8040206@vmware.com \
    --to=msnyder@vmware.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox