Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] fix crasher on detach command
Date: Mon, 07 Jun 2010 19:09:00 -0000	[thread overview]
Message-ID: <201006072008.51363.pedro@codesourcery.com> (raw)
In-Reply-To: <4C0D41B4.3020008@vmware.com>

On Monday 07 June 2010 20:00:04, Michael Snyder wrote:
> > Then we need to fix that, instead of adding workarounds in other
> > areas.
> 
> I'm not sure how feasible that is.  At this point I've had to use a
> ^C^C to get out of a failing attach (target remote), and I'm hoping to
> use the "detach" to cancel out any remaining inconsistent state.
> The ^C^C handler can't necessarily do it by itself, 'cause from its
> point of view, you don't really know what state you're in or what
> state you want to be in.

It's feasible.  remote_open_1 + remote_start_remote and remote_close
(usually from pop_target calls within remote.c) are all designed for
this to not happen, but clearly there's a bug somewhere.  It just
sounds like there's something not exception safe that should be.

-- 
Pedro Alves


  reply	other threads:[~2010-06-07 19:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-07 18:11 Michael Snyder
2010-06-07 18:28 ` Pedro Alves
2010-06-07 18:31   ` Michael Snyder
2010-06-07 18:37     ` Pedro Alves
2010-06-07 19:00       ` Michael Snyder
2010-06-07 19:09         ` Pedro Alves [this message]
2010-06-07 19:12           ` Pedro Alves
2010-06-07 23:50             ` Michael Snyder
2010-06-08 12:56               ` Pedro Alves
2010-06-08  0:11             ` Michael Snyder
2010-06-08 12:59               ` Pedro Alves
2010-06-08 16:52                 ` Michael Snyder
2010-06-08  2:42   ` Hui Zhu
2010-06-08 12:54     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201006072008.51363.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox