Re: [patch][python] Add breakpoint support.

[Phil Muldoon <pmuldoon@redhat.com>]

On 04/08/2010 04:29 PM, Joel Brobecker wrote:
>> I've replaced the BPPY_VALID_P macro with a static function in this
>> patch.  I also updated the s/ask/task typo.  What do you think?
> 
> Seems good to commit to me. Unless Tom wants to take a look, just go
> ahead.  There are a comple of nit that I noticed:
> 
>> +  {NULL} /* Sentinel. */
>> +  {NULL} /* Sentinel. */
> 
> Can you add a second space after the period?
> 
>> +/* Python function to set the (ADA) task of a breakpoint.  */
> 
> That's a bit pedantic, but since we're fixing a formatting nit above,
> can you spell the language "Ada" (the language was named after Lady Ada
> Lovelace) and we don't want to be confused with the American Donkey
> Association :-) :-) :-).

Sure done. I won't repost a patch for these, but in my local tree they
are changed.


 
> Thank you for pushing this to the FSF tree, I'm really excited to see
> the python API getting expanded. 


It's my pleasure and a fun thing to do. 



In particular, I think your patch makes
> it possible to implement relatively simply a python a couple of routines
> that saves/restores breakpoints on/from file. For instance, we could add
> a couple of methods that do just that... (for a rainy day, which seems
> to have been the norm this past week in Vancouver).


There is a save_breakpoints.py script in the archer repository
already, so a lot of the work is done. I have a patch to modify that
to save watchpoints too.  I've not ported it here today as I purely
want to concentrate on the API aspect of porting. But there is really
no reason why it can't go in immediately as part of another porting
effort. I  think it would need some make/configure hackery to install,
which is definitely my weakest area.


Cheers,

Phil