From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12193 invoked by alias); 8 Apr 2010 19:48:49 -0000 Received: (qmail 12184 invoked by uid 22791); 8 Apr 2010 19:48:49 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Apr 2010 19:48:43 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o38JmIPT003469 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 8 Apr 2010 15:48:18 -0400 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o38JmFp2000914; Thu, 8 Apr 2010 15:48:16 -0400 Message-ID: <4BBE32FF.8090508@redhat.com> Date: Thu, 08 Apr 2010 19:48:00 -0000 From: Phil Muldoon User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.3 MIME-Version: 1.0 To: Joel Brobecker CC: Tom Tromey , gdb-patches ml , Eli Zaretskii Subject: Re: [patch][python] Add breakpoint support. References: <4BB0B063.6000600@redhat.com> <20100405162648.GD19194@adacore.com> <4BBB3AF6.8050407@redhat.com> <4BBDCF0E.9020904@redhat.com> <20100408152905.GK19194@adacore.com> In-Reply-To: <20100408152905.GK19194@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00187.txt.bz2 On 04/08/2010 04:29 PM, Joel Brobecker wrote: >> I've replaced the BPPY_VALID_P macro with a static function in this >> patch. I also updated the s/ask/task typo. What do you think? > > Seems good to commit to me. Unless Tom wants to take a look, just go > ahead. There are a comple of nit that I noticed: > >> + {NULL} /* Sentinel. */ >> + {NULL} /* Sentinel. */ > > Can you add a second space after the period? > >> +/* Python function to set the (ADA) task of a breakpoint. */ > > That's a bit pedantic, but since we're fixing a formatting nit above, > can you spell the language "Ada" (the language was named after Lady Ada > Lovelace) and we don't want to be confused with the American Donkey > Association :-) :-) :-). Sure done. I won't repost a patch for these, but in my local tree they are changed. > Thank you for pushing this to the FSF tree, I'm really excited to see > the python API getting expanded. It's my pleasure and a fun thing to do. In particular, I think your patch makes > it possible to implement relatively simply a python a couple of routines > that saves/restores breakpoints on/from file. For instance, we could add > a couple of methods that do just that... (for a rainy day, which seems > to have been the norm this past week in Vancouver). There is a save_breakpoints.py script in the archer repository already, so a lot of the work is done. I have a patch to modify that to save watchpoints too. I've not ported it here today as I purely want to concentrate on the API aspect of porting. But there is really no reason why it can't go in immediately as part of another porting effort. I think it would need some make/configure hackery to install, which is definitely my weakest area. Cheers, Phil