Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Phil Muldoon <pmuldoon@redhat.com>,
		Tom Tromey <tromey@redhat.com>, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch][python] Add breakpoint support.
Date: Thu, 08 Apr 2010 23:26:00 -0000	[thread overview]
Message-ID: <20100408232547.GN19194@adacore.com> (raw)
In-Reply-To: <201004082321.01822.pedro@codesourcery.com>

> I'd just like to point out that we already have code in the tree (and
> for a decade) that dumps tracepoints into a file; the file can be
> sourced as a cli script afterwards.  See breakpoint.c:tracepoint_save_command.
> Since the tracepoint/breakpoints merge, it is trivial to extend that function
> to dump breakpoints as well.

I almost did implement things that way, and it's certainly better
than nothing. Maybe I'm letting best be the enemy of good, but there
are issues with a pure CLI script approach that a user cannot control.
For instance, what if one of the breakpoints now fails? A CLI script
would abort early, leaving some of the breakpoints not restored.
If some of the breakpoints were in DSOs that only get loaded at runtime,
should they be created as pending? I can't remember what the default
is when from_tty is not set...  I like the python approach because it
allows us to provide a more configurable approach than a pure CLI script
would give us.

-- 
Joel


  reply	other threads:[~2010-04-08 23:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-29 13:52 Phil Muldoon
2010-03-29 14:28 ` Eli Zaretskii
2010-03-29 14:53   ` Phil Muldoon
2010-03-29 15:15     ` Eli Zaretskii
2010-04-05 16:27 ` Joel Brobecker
2010-04-06 13:47   ` Phil Muldoon
2010-04-06 18:21     ` Eli Zaretskii
2010-04-07 21:09     ` Tom Tromey
2010-04-08 12:42       ` Phil Muldoon
2010-04-08 15:29         ` Joel Brobecker
2010-04-08 19:48           ` Phil Muldoon
2010-04-08 20:41             ` Tom Tromey
2010-04-08 21:27               ` Phil Muldoon
2010-04-08 21:45                 ` Joel Brobecker
2010-04-08 22:21                   ` Pedro Alves
2010-04-08 23:26                     ` Joel Brobecker [this message]
2010-04-08 23:40                       ` Pedro Alves
2010-04-09 15:35                       ` Tom Tromey
2010-04-09 15:32                   ` Tom Tromey
2010-04-08 19:57         ` Tom Tromey
2010-04-09 10:11           ` Phil Muldoon
2010-04-07 21:19     ` Joel Brobecker
2010-06-11 17:41     ` Ulrich Weigand
2010-06-11 20:28       ` Phil Muldoon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100408232547.GN19194@adacore.com \
    --to=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    --cc=pmuldoon@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox