Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: tromey@redhat.com, gdb-patches ml <gdb-patches@sourceware.org>,
		Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch][python] Add breakpoint support.
Date: Thu, 08 Apr 2010 15:29:00 -0000	[thread overview]
Message-ID: <20100408152905.GK19194@adacore.com> (raw)
In-Reply-To: <4BBDCF0E.9020904@redhat.com>

> I've replaced the BPPY_VALID_P macro with a static function in this
> patch.  I also updated the s/ask/task typo.  What do you think?

Seems good to commit to me. Unless Tom wants to take a look, just go
ahead.  There are a comple of nit that I noticed:

> +  {NULL} /* Sentinel. */
> +  {NULL} /* Sentinel. */

Can you add a second space after the period?

> +/* Python function to set the (ADA) task of a breakpoint.  */

That's a bit pedantic, but since we're fixing a formatting nit above,
can you spell the language "Ada" (the language was named after Lady Ada
Lovelace) and we don't want to be confused with the American Donkey
Association :-) :-) :-).

Thank you for pushing this to the FSF tree, I'm really excited to see
the python API getting expanded. In particular, I think your patch makes
it possible to implement relatively simply a python a couple of routines
that saves/restores breakpoints on/from file. For instance, we could add
a couple of methods that do just that... (for a rainy day, which seems
to have been the norm this past week in Vancouver).

-- 
Joel


  reply	other threads:[~2010-04-08 15:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-29 13:52 Phil Muldoon
2010-03-29 14:28 ` Eli Zaretskii
2010-03-29 14:53   ` Phil Muldoon
2010-03-29 15:15     ` Eli Zaretskii
2010-04-05 16:27 ` Joel Brobecker
2010-04-06 13:47   ` Phil Muldoon
2010-04-06 18:21     ` Eli Zaretskii
2010-04-07 21:09     ` Tom Tromey
2010-04-08 12:42       ` Phil Muldoon
2010-04-08 15:29         ` Joel Brobecker [this message]
2010-04-08 19:48           ` Phil Muldoon
2010-04-08 20:41             ` Tom Tromey
2010-04-08 21:27               ` Phil Muldoon
2010-04-08 21:45                 ` Joel Brobecker
2010-04-08 22:21                   ` Pedro Alves
2010-04-08 23:26                     ` Joel Brobecker
2010-04-08 23:40                       ` Pedro Alves
2010-04-09 15:35                       ` Tom Tromey
2010-04-09 15:32                   ` Tom Tromey
2010-04-08 19:57         ` Tom Tromey
2010-04-09 10:11           ` Phil Muldoon
2010-04-07 21:19     ` Joel Brobecker
2010-06-11 17:41     ` Ulrich Weigand
2010-06-11 20:28       ` Phil Muldoon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100408152905.GK19194@adacore.com \
    --to=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox