From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8242 invoked by alias); 8 Apr 2010 15:29:22 -0000 Received: (qmail 8231 invoked by uid 22791); 8 Apr 2010 15:29:21 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Apr 2010 15:29:16 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 359B02BABBF; Thu, 8 Apr 2010 11:29:15 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id uLR6o5LTTPYQ; Thu, 8 Apr 2010 11:29:15 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7F3072BABFE; Thu, 8 Apr 2010 11:29:14 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id B3499F58C2; Thu, 8 Apr 2010 08:29:05 -0700 (PDT) Date: Thu, 08 Apr 2010 15:29:00 -0000 From: Joel Brobecker To: Phil Muldoon Cc: tromey@redhat.com, gdb-patches ml , Eli Zaretskii Subject: Re: [patch][python] Add breakpoint support. Message-ID: <20100408152905.GK19194@adacore.com> References: <4BB0B063.6000600@redhat.com> <20100405162648.GD19194@adacore.com> <4BBB3AF6.8050407@redhat.com> <4BBDCF0E.9020904@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4BBDCF0E.9020904@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00177.txt.bz2 > I've replaced the BPPY_VALID_P macro with a static function in this > patch. I also updated the s/ask/task typo. What do you think? Seems good to commit to me. Unless Tom wants to take a look, just go ahead. There are a comple of nit that I noticed: > + {NULL} /* Sentinel. */ > + {NULL} /* Sentinel. */ Can you add a second space after the period? > +/* Python function to set the (ADA) task of a breakpoint. */ That's a bit pedantic, but since we're fixing a formatting nit above, can you spell the language "Ada" (the language was named after Lady Ada Lovelace) and we don't want to be confused with the American Donkey Association :-) :-) :-). Thank you for pushing this to the FSF tree, I'm really excited to see the python API getting expanded. In particular, I think your patch makes it possible to implement relatively simply a python a couple of routines that saves/restores breakpoints on/from file. For instance, we could add a couple of methods that do just that... (for a rainy day, which seems to have been the norm this past week in Vancouver). -- Joel