Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: pmuldoon@redhat.com (Phil Muldoon)
Cc: brobecker@adacore.com (Joel Brobecker),
	       gdb-patches@sourceware.org (gdb-patches ml),
	       eliz@gnu.org (Eli Zaretskii)
Subject: Re: [patch][python] Add breakpoint support.
Date: Fri, 11 Jun 2010 17:41:00 -0000	[thread overview]
Message-ID: <201006111741.o5BHfABg004677@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <4BBB3AF6.8050407@redhat.com> from "Phil Muldoon" at Apr 06, 2010 02:45:26 PM

Phil Muldoon wrote:

> +gdb_py_test_silent_cmd  "python wp1 = gdb.Breakpoint (\"result\", type=gdb.BP_WATCHPOINT, wp_class=gdb.WP_WRITE )" "Set watchpoint" 0
> +gdb_test "continue" ".*watchpoint.*result.*Old value = 0.*New value = 25.*main.*" "Test watchpoint write"

This fails on platforms with software watchpoints, because they use "Watchpoint"
instead of "Hardware watchpoint".  Fixed by allowing "W" as well as "w" like
most other watchpoint related tests do.

Tested on spu-elf, committed to mainline.

Bye,
Ulrich

ChangeLog:

	* gdb.python/py-breakpoint.exp: Handle software watchpoints as well.

Index: gdb/testsuite/gdb.python/py-breakpoint.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.python/py-breakpoint.exp,v
retrieving revision 1.1
diff -u -p -r1.1 py-breakpoint.exp
--- gdb/testsuite/gdb.python/py-breakpoint.exp	9 Apr 2010 09:41:43 -0000	1.1
+++ gdb/testsuite/gdb.python/py-breakpoint.exp	11 Jun 2010 16:43:07 -0000
@@ -136,7 +136,7 @@ if ![runto_main] then {
 }
 
 gdb_py_test_silent_cmd  "python wp1 = gdb.Breakpoint (\"result\", type=gdb.BP_WATCHPOINT, wp_class=gdb.WP_WRITE )" "Set watchpoint" 0
-gdb_test "continue" ".*watchpoint.*result.*Old value = 0.*New value = 25.*main.*" "Test watchpoint write"
+gdb_test "continue" ".*\[Ww\]atchpoint.*result.*Old value = 0.*New value = 25.*main.*" "Test watchpoint write"
 
 
 


-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  parent reply	other threads:[~2010-06-11 17:41 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-29 13:52 Phil Muldoon
2010-03-29 14:28 ` Eli Zaretskii
2010-03-29 14:53   ` Phil Muldoon
2010-03-29 15:15     ` Eli Zaretskii
2010-04-05 16:27 ` Joel Brobecker
2010-04-06 13:47   ` Phil Muldoon
2010-04-06 18:21     ` Eli Zaretskii
2010-04-07 21:09     ` Tom Tromey
2010-04-08 12:42       ` Phil Muldoon
2010-04-08 15:29         ` Joel Brobecker
2010-04-08 19:48           ` Phil Muldoon
2010-04-08 20:41             ` Tom Tromey
2010-04-08 21:27               ` Phil Muldoon
2010-04-08 21:45                 ` Joel Brobecker
2010-04-08 22:21                   ` Pedro Alves
2010-04-08 23:26                     ` Joel Brobecker
2010-04-08 23:40                       ` Pedro Alves
2010-04-09 15:35                       ` Tom Tromey
2010-04-09 15:32                   ` Tom Tromey
2010-04-08 19:57         ` Tom Tromey
2010-04-09 10:11           ` Phil Muldoon
2010-04-07 21:19     ` Joel Brobecker
2010-06-11 17:41     ` Ulrich Weigand [this message]
2010-06-11 20:28       ` Phil Muldoon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201006111741.o5BHfABg004677@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox