From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15390 invoked by alias); 11 Jun 2010 17:41:23 -0000 Received: (qmail 15375 invoked by uid 22791); 11 Jun 2010 17:41:21 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate7.de.ibm.com (HELO mtagate7.de.ibm.com) (195.212.17.167) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Jun 2010 17:41:16 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.13.1/8.13.1) with ESMTP id o5BHfCcm021981 for ; Fri, 11 Jun 2010 17:41:12 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o5BHfC3o1282150 for ; Fri, 11 Jun 2010 19:41:12 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o5BHfBUJ004698 for ; Fri, 11 Jun 2010 19:41:12 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id o5BHfABg004677; Fri, 11 Jun 2010 19:41:10 +0200 Message-Id: <201006111741.o5BHfABg004677@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Fri, 11 Jun 2010 19:41:10 +0200 Subject: Re: [patch][python] Add breakpoint support. To: pmuldoon@redhat.com (Phil Muldoon) Date: Fri, 11 Jun 2010 17:41:00 -0000 From: "Ulrich Weigand" Cc: brobecker@adacore.com (Joel Brobecker), gdb-patches@sourceware.org (gdb-patches ml), eliz@gnu.org (Eli Zaretskii) In-Reply-To: <4BBB3AF6.8050407@redhat.com> from "Phil Muldoon" at Apr 06, 2010 02:45:26 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00276.txt.bz2 Phil Muldoon wrote: > +gdb_py_test_silent_cmd "python wp1 = gdb.Breakpoint (\"result\", type=gdb.BP_WATCHPOINT, wp_class=gdb.WP_WRITE )" "Set watchpoint" 0 > +gdb_test "continue" ".*watchpoint.*result.*Old value = 0.*New value = 25.*main.*" "Test watchpoint write" This fails on platforms with software watchpoints, because they use "Watchpoint" instead of "Hardware watchpoint". Fixed by allowing "W" as well as "w" like most other watchpoint related tests do. Tested on spu-elf, committed to mainline. Bye, Ulrich ChangeLog: * gdb.python/py-breakpoint.exp: Handle software watchpoints as well. Index: gdb/testsuite/gdb.python/py-breakpoint.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.python/py-breakpoint.exp,v retrieving revision 1.1 diff -u -p -r1.1 py-breakpoint.exp --- gdb/testsuite/gdb.python/py-breakpoint.exp 9 Apr 2010 09:41:43 -0000 1.1 +++ gdb/testsuite/gdb.python/py-breakpoint.exp 11 Jun 2010 16:43:07 -0000 @@ -136,7 +136,7 @@ if ![runto_main] then { } gdb_py_test_silent_cmd "python wp1 = gdb.Breakpoint (\"result\", type=gdb.BP_WATCHPOINT, wp_class=gdb.WP_WRITE )" "Set watchpoint" 0 -gdb_test "continue" ".*watchpoint.*result.*Old value = 0.*New value = 25.*main.*" "Test watchpoint write" +gdb_test "continue" ".*\[Ww\]atchpoint.*result.*Old value = 0.*New value = 25.*main.*" "Test watchpoint write" -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com