Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Chet Ramey <chet.ramey@case.edu>
To: "H. J. Lu" <hjl@lucon.org>, GDB <gdb-patches@sources.redhat.com>,
	        jkratoch@redhat.com
Cc: bug-readline@gnu.org, chet.ramey@case.edu
Subject: Re: PATCH: PR tui/2173: Arrow keys no longer works in breakpoint  command list
Date: Sat, 02 Dec 2006 19:17:00 -0000	[thread overview]
Message-ID: <4571D13B.1030006@case.edu> (raw)
In-Reply-To: <20061202185548.GA11402@nevyn.them.org>

Daniel Jacobowitz wrote:
> On Sat, Dec 02, 2006 at 10:43:44AM -0800, H. J. Lu wrote:
>> 2006-12-02  H.J. Lu  <hongjiu.lu@intel.com>
>> 	    Jan Kratochvil <jkratoch@redhat.com>
>>
>> 	PR tui/2173
>> 	* readline.c (readline): Unset and reset RL_STATE_CALLBACK if
>> 	needed.
> 
> This looks reasonable to me; I was wrong about longjmp since Readline's
> signal handlers will be installed.  If Chet accepts this or a similar
> fix for the next release of readline, then you can apply it to our
> copy.

In general, readline's signal handlers will restore any application-
installed handlers before resending the signal to itself.  This means
that any signal can potentially cause an application's handler to be
called, and longjmp to be called from that.

Now we would be relying on the application's signal handler to restore
the appropriate readline state.

Chet
-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
		       Live Strong.  No day but today.
Chet Ramey, ITS, CWRU    chet@case.edu    http://cnswww.cns.cwru.edu/~chet/


  parent reply	other threads:[~2006-12-02 19:17 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-21 21:32 H. J. Lu
2006-11-28 16:53 ` Daniel Jacobowitz
2006-11-28 17:09   ` H. J. Lu
2006-11-28 17:15     ` Daniel Jacobowitz
2006-12-02 18:44     ` H. J. Lu
2006-12-02 18:55       ` Daniel Jacobowitz
2006-12-02 18:59         ` Joel Brobecker
2006-12-02 19:17         ` Chet Ramey [this message]
2006-12-02 19:09       ` Chet Ramey
2006-12-02 22:15         ` H. J. Lu
2006-12-02 23:06           ` Daniel Jacobowitz
2006-12-03  5:25           ` Chet Ramey
2006-12-17 23:46             ` Jan Kratochvil
2006-12-18 20:09               ` Chet Ramey
2006-12-19 23:20                 ` Jan Kratochvil
2006-12-26  6:00                   ` Jan Kratochvil
2007-01-03 21:46                     ` Daniel Jacobowitz
2007-01-03 21:47                       ` Daniel Jacobowitz
     [not found] <18019.18081.448928.93993@kahikatea.snap.net.nz>
     [not found] ` <20070604010633.GA927@caradoc.them.org>
2007-06-05 12:56   ` Nick Roberts
2007-06-05 13:27     ` Daniel Jacobowitz
2007-06-24 15:46       ` Daniel Jacobowitz
2007-06-24 21:55         ` Nick Roberts
2007-07-01 22:38           ` Daniel Jacobowitz
2007-07-03  1:28             ` Nick Roberts
2007-07-03  3:03               ` Daniel Jacobowitz
2007-07-03 15:39               ` Daniel Jacobowitz
2007-06-26 13:49   ` Jan Kratochvil
2007-06-26 14:33     ` Daniel Jacobowitz
2008-03-21 20:34     ` Jan Kratochvil
2008-03-21 21:22       ` Daniel Jacobowitz
2008-03-21 21:26         ` Jan Kratochvil
2008-03-21 21:41           ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4571D13B.1030006@case.edu \
    --to=chet.ramey@case.edu \
    --cc=bug-readline@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=hjl@lucon.org \
    --cc=jkratoch@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox