From: Daniel Jacobowitz <drow@false.org>
To: "H. J. Lu" <hjl@lucon.org>
Cc: GDB <gdb-patches@sources.redhat.com>
Subject: Re: PATCH: PR tui/2173: Arrow keys no longer works in breakpoint command list
Date: Tue, 28 Nov 2006 16:53:00 -0000 [thread overview]
Message-ID: <20061128164658.GB20882@nevyn.them.org> (raw)
In-Reply-To: <20061121213205.GA13310@lucon.org>
On Tue, Nov 21, 2006 at 01:32:05PM -0800, H. J. Lu wrote:
> The problem is callback in readline 5.1 is changed. When gdb readline
> callback calls readline (), readline is really confused since although
> it is called from gdb callback, it isn't really in callback state. This
> kludge seems to work for me.
I'm pretty sure this isn't right. I got as far as figuring out that we
should be calling rl_callback_handler_install and
rl_callback_handler_remove at different times, always removing the
handler before calling readline recursively, but I couldn't quite work
out the right conditions.
What would be really best would be to stop calling readline directly;
make the whole thing involve the event loop, just like top level
command line editing. That's going to be a bit of work though.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-11-28 16:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-21 21:32 H. J. Lu
2006-11-28 16:53 ` Daniel Jacobowitz [this message]
2006-11-28 17:09 ` H. J. Lu
2006-11-28 17:15 ` Daniel Jacobowitz
2006-12-02 18:44 ` H. J. Lu
2006-12-02 18:55 ` Daniel Jacobowitz
2006-12-02 18:59 ` Joel Brobecker
2006-12-02 19:17 ` Chet Ramey
2006-12-02 19:09 ` Chet Ramey
2006-12-02 22:15 ` H. J. Lu
2006-12-02 23:06 ` Daniel Jacobowitz
2006-12-03 5:25 ` Chet Ramey
2006-12-17 23:46 ` Jan Kratochvil
2006-12-18 20:09 ` Chet Ramey
2006-12-19 23:20 ` Jan Kratochvil
2006-12-26 6:00 ` Jan Kratochvil
2007-01-03 21:46 ` Daniel Jacobowitz
2007-01-03 21:47 ` Daniel Jacobowitz
[not found] <18019.18081.448928.93993@kahikatea.snap.net.nz>
[not found] ` <20070604010633.GA927@caradoc.them.org>
2007-06-05 12:56 ` Nick Roberts
2007-06-05 13:27 ` Daniel Jacobowitz
2007-06-24 15:46 ` Daniel Jacobowitz
2007-06-24 21:55 ` Nick Roberts
2007-07-01 22:38 ` Daniel Jacobowitz
2007-07-03 1:28 ` Nick Roberts
2007-07-03 3:03 ` Daniel Jacobowitz
2007-07-03 15:39 ` Daniel Jacobowitz
2007-06-26 13:49 ` Jan Kratochvil
2007-06-26 14:33 ` Daniel Jacobowitz
2008-03-21 20:34 ` Jan Kratochvil
2008-03-21 21:22 ` Daniel Jacobowitz
2008-03-21 21:26 ` Jan Kratochvil
2008-03-21 21:41 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061128164658.GB20882@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=hjl@lucon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox