Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: "H. J. Lu" <hjl@lucon.org>
Cc: Chet Ramey <chet.ramey@case.edu>,
	GDB <gdb-patches@sources.redhat.com>,
		jkratoch@redhat.com, bug-readline@gnu.org, chet@case.edu
Subject: Re: PATCH: PR tui/2173: Arrow keys no longer works in breakpoint command list
Date: Sat, 02 Dec 2006 23:06:00 -0000	[thread overview]
Message-ID: <20061202230558.GA17363@nevyn.them.org> (raw)
In-Reply-To: <20061202221541.GA9776@lucon.org>

On Sat, Dec 02, 2006 at 02:15:41PM -0800, H. J. Lu wrote:
> > There should be no reason that the application cannot remove the callback
> > handler and re-add it before calling readline synchronously, as Daniel or
> > H.J. suggested.  The application is the only one in a position to know
> > which is right.
> > 
> 
> Did you mean
> 
> http://sources.redhat.com/ml/gdb-patches/2006-11/msg00234.html
> 
> is more appropriate?

HJ, did you even read my response?

Messing about with RL_SETSTATE and RL_UNSETSTATE in GDB is not wise and
we should not be doing it.  We should be manually removing our
callbacks before we call readline synchronously, as I wrote in reply to
your message.  Someone is going to need to really understand the
different paths that take us into readline to work out where to do it.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-12-02 23:06 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-21 21:32 H. J. Lu
2006-11-28 16:53 ` Daniel Jacobowitz
2006-11-28 17:09   ` H. J. Lu
2006-11-28 17:15     ` Daniel Jacobowitz
2006-12-02 18:44     ` H. J. Lu
2006-12-02 18:55       ` Daniel Jacobowitz
2006-12-02 18:59         ` Joel Brobecker
2006-12-02 19:17         ` Chet Ramey
2006-12-02 19:09       ` Chet Ramey
2006-12-02 22:15         ` H. J. Lu
2006-12-02 23:06           ` Daniel Jacobowitz [this message]
2006-12-03  5:25           ` Chet Ramey
2006-12-17 23:46             ` Jan Kratochvil
2006-12-18 20:09               ` Chet Ramey
2006-12-19 23:20                 ` Jan Kratochvil
2006-12-26  6:00                   ` Jan Kratochvil
2007-01-03 21:46                     ` Daniel Jacobowitz
2007-01-03 21:47                       ` Daniel Jacobowitz
     [not found] <18019.18081.448928.93993@kahikatea.snap.net.nz>
     [not found] ` <20070604010633.GA927@caradoc.them.org>
2007-06-05 12:56   ` Nick Roberts
2007-06-05 13:27     ` Daniel Jacobowitz
2007-06-24 15:46       ` Daniel Jacobowitz
2007-06-24 21:55         ` Nick Roberts
2007-07-01 22:38           ` Daniel Jacobowitz
2007-07-03  1:28             ` Nick Roberts
2007-07-03  3:03               ` Daniel Jacobowitz
2007-07-03 15:39               ` Daniel Jacobowitz
2007-06-26 13:49   ` Jan Kratochvil
2007-06-26 14:33     ` Daniel Jacobowitz
2008-03-21 20:34     ` Jan Kratochvil
2008-03-21 21:22       ` Daniel Jacobowitz
2008-03-21 21:26         ` Jan Kratochvil
2008-03-21 21:41           ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061202230558.GA17363@nevyn.them.org \
    --to=drow@false.org \
    --cc=bug-readline@gnu.org \
    --cc=chet.ramey@case.edu \
    --cc=chet@case.edu \
    --cc=gdb-patches@sources.redhat.com \
    --cc=hjl@lucon.org \
    --cc=jkratoch@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox