From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24614 invoked by alias); 2 Dec 2006 23:06:07 -0000 Received: (qmail 24602 invoked by uid 22791); 2 Dec 2006 23:06:06 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sat, 02 Dec 2006 23:06:02 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1Gqdvi-0004Wj-JL; Sat, 02 Dec 2006 18:05:58 -0500 Date: Sat, 02 Dec 2006 23:06:00 -0000 From: Daniel Jacobowitz To: "H. J. Lu" Cc: Chet Ramey , GDB , jkratoch@redhat.com, bug-readline@gnu.org, chet@case.edu Subject: Re: PATCH: PR tui/2173: Arrow keys no longer works in breakpoint command list Message-ID: <20061202230558.GA17363@nevyn.them.org> Mail-Followup-To: "H. J. Lu" , Chet Ramey , GDB , jkratoch@redhat.com, bug-readline@gnu.org, chet@case.edu References: <20061121213205.GA13310@lucon.org> <20061128164658.GB20882@nevyn.them.org> <20061128165844.GA13667@lucon.org> <20061202184344.GA2197@lucon.org> <4571CF2A.3040608@case.edu> <20061202221541.GA9776@lucon.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061202221541.GA9776@lucon.org> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00016.txt.bz2 On Sat, Dec 02, 2006 at 02:15:41PM -0800, H. J. Lu wrote: > > There should be no reason that the application cannot remove the callback > > handler and re-add it before calling readline synchronously, as Daniel or > > H.J. suggested. The application is the only one in a position to know > > which is right. > > > > Did you mean > > http://sources.redhat.com/ml/gdb-patches/2006-11/msg00234.html > > is more appropriate? HJ, did you even read my response? Messing about with RL_SETSTATE and RL_UNSETSTATE in GDB is not wise and we should not be doing it. We should be manually removing our callbacks before we call readline synchronously, as I wrote in reply to your message. Someone is going to need to really understand the different paths that take us into readline to work out where to do it. -- Daniel Jacobowitz CodeSourcery