Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Chet Ramey <chet.ramey@case.edu>
Cc: "H. J. Lu" <hjl@lucon.org>, GDB <gdb-patches@sources.redhat.com>,
	        bug-readline@gnu.org
Subject: Re: PATCH: PR tui/2173: Arrow keys no longer works in breakpoint command list
Date: Tue, 19 Dec 2006 23:20:00 -0000	[thread overview]
Message-ID: <20061219231926.GA20632@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <4586F56F.5040304@case.edu>

Hi Chet,


On Mon, 18 Dec 2006 21:09:19 +0100, Chet Ramey wrote:
...
> Not exactly.  The callback and traditional calling mechanisms are
> orthogonal.  It's just not safe to mix them.  The longjmp leaves
> readline in an inconsistent state, unless the calling application is
> careful to undo what state-setting it has done.  That's the part
> readline can't know about:  the appropriate application-specific part.

OK, so going to provide callback based GDB reimplementation of
gdb_readline_wrapper () (readline () call).


> > The sample code should be readline documentation compliant, still the called
> > function `_rl_next_macro_key' has undeterministic value of
> > `RL_ISSTATE (RL_STATE_CALLBACK)'.
> 
> OK, you got me.  I'll fix that one, if I can find it.  I can't find a call
> to that function in the examples/ or doc/ directories.

rl_read_key () calls _rl_next_macro_key () and rl_read_key () can be called by
the application.  I did not check how much serious is a fail of this mode check
but I assume there are other functions callable by the application this way.


Regards,
Jan


  reply	other threads:[~2006-12-19 23:20 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-21 21:32 H. J. Lu
2006-11-28 16:53 ` Daniel Jacobowitz
2006-11-28 17:09   ` H. J. Lu
2006-11-28 17:15     ` Daniel Jacobowitz
2006-12-02 18:44     ` H. J. Lu
2006-12-02 18:55       ` Daniel Jacobowitz
2006-12-02 18:59         ` Joel Brobecker
2006-12-02 19:17         ` Chet Ramey
2006-12-02 19:09       ` Chet Ramey
2006-12-02 22:15         ` H. J. Lu
2006-12-02 23:06           ` Daniel Jacobowitz
2006-12-03  5:25           ` Chet Ramey
2006-12-17 23:46             ` Jan Kratochvil
2006-12-18 20:09               ` Chet Ramey
2006-12-19 23:20                 ` Jan Kratochvil [this message]
2006-12-26  6:00                   ` Jan Kratochvil
2007-01-03 21:46                     ` Daniel Jacobowitz
2007-01-03 21:47                       ` Daniel Jacobowitz
     [not found] <18019.18081.448928.93993@kahikatea.snap.net.nz>
     [not found] ` <20070604010633.GA927@caradoc.them.org>
2007-06-05 12:56   ` Nick Roberts
2007-06-05 13:27     ` Daniel Jacobowitz
2007-06-24 15:46       ` Daniel Jacobowitz
2007-06-24 21:55         ` Nick Roberts
2007-07-01 22:38           ` Daniel Jacobowitz
2007-07-03  1:28             ` Nick Roberts
2007-07-03  3:03               ` Daniel Jacobowitz
2007-07-03 15:39               ` Daniel Jacobowitz
2007-06-26 13:49   ` Jan Kratochvil
2007-06-26 14:33     ` Daniel Jacobowitz
2008-03-21 20:34     ` Jan Kratochvil
2008-03-21 21:22       ` Daniel Jacobowitz
2008-03-21 21:26         ` Jan Kratochvil
2008-03-21 21:41           ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061219231926.GA20632@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=bug-readline@gnu.org \
    --cc=chet.ramey@case.edu \
    --cc=gdb-patches@sources.redhat.com \
    --cc=hjl@lucon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox