From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-46314-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5367 invoked by alias); 28 Nov 2006 16:53:45 -0000
Received: (qmail 31725 invoked by uid 22791); 28 Nov 2006 16:47:19 -0000
X-Spam-Check-By: sourceware.org
Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17)     by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 28 Nov 2006 16:47:01 +0000
Received: from drow by nevyn.them.org with local (Exim 4.63) 	(envelope-from <drow@nevyn.them.org>) 	id 1Gp66k-0005f8-IJ; Tue, 28 Nov 2006 11:46:58 -0500
Date: Tue, 28 Nov 2006 16:53:00 -0000
From: Daniel Jacobowitz <drow@false.org>
To: "H. J. Lu" <hjl@lucon.org>
Cc: GDB <gdb-patches@sources.redhat.com>
Subject: Re: PATCH: PR tui/2173: Arrow keys no longer works in breakpoint command list
Message-ID: <20061128164658.GB20882@nevyn.them.org>
Mail-Followup-To: "H. J. Lu" <hjl@lucon.org>, 	GDB <gdb-patches@sources.redhat.com>
References: <20061121213205.GA13310@lucon.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20061121213205.GA13310@lucon.org>
User-Agent: Mutt/1.5.13 (2006-08-11)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-11/txt/msg00318.txt.bz2

On Tue, Nov 21, 2006 at 01:32:05PM -0800, H. J. Lu wrote:
> The problem is callback in readline 5.1 is changed. When gdb readline
> callback calls readline (), readline is really confused since although
> it is called from gdb callback, it isn't really in callback state. This
> kludge seems to work for me.

I'm pretty sure this isn't right.  I got as far as figuring out that we
should be calling rl_callback_handler_install and
rl_callback_handler_remove at different times, always removing the
handler before calling readline recursively, but I couldn't quite work
out the right conditions.

What would be really best would be to stop calling readline directly;
make the whole thing involve the event loop, just like top level
command line editing.  That's going to be a bit of work though.


-- 
Daniel Jacobowitz
CodeSourcery