From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19908 invoked by alias); 2 Dec 2006 19:17:38 -0000 Received: (qmail 19899 invoked by uid 22791); 2 Dec 2006 19:17:37 -0000 X-Spam-Check-By: sourceware.org Received: from mpv4.TIS.CWRU.Edu (HELO mpv4.tis.cwru.edu) (129.22.105.34) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 02 Dec 2006 19:17:32 +0000 Received: from [192.168.1.101] ([71.31.155.76]) by mpv4.tis.cwru.edu (MOS 3.8.2-GA) with ESMTP id BUU96372 (AUTH cpr); Sat, 2 Dec 2006 14:17:17 -0500 (EST) Message-ID: <4571D13B.1030006@case.edu> Date: Sat, 02 Dec 2006 19:17:00 -0000 From: Chet Ramey Reply-To: chet.ramey@case.edu User-Agent: Thunderbird 1.5.0.8 (Macintosh/20061025) MIME-Version: 1.0 To: "H. J. Lu" , GDB , jkratoch@redhat.com CC: bug-readline@gnu.org, chet.ramey@case.edu Subject: Re: PATCH: PR tui/2173: Arrow keys no longer works in breakpoint command list References: <20061121213205.GA13310@lucon.org> <20061128164658.GB20882@nevyn.them.org> <20061128165844.GA13667@lucon.org> <20061202184344.GA2197@lucon.org> <20061202185548.GA11402@nevyn.them.org> In-Reply-To: <20061202185548.GA11402@nevyn.them.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00013.txt.bz2 Daniel Jacobowitz wrote: > On Sat, Dec 02, 2006 at 10:43:44AM -0800, H. J. Lu wrote: >> 2006-12-02 H.J. Lu >> Jan Kratochvil >> >> PR tui/2173 >> * readline.c (readline): Unset and reset RL_STATE_CALLBACK if >> needed. > > This looks reasonable to me; I was wrong about longjmp since Readline's > signal handlers will be installed. If Chet accepts this or a similar > fix for the next release of readline, then you can apply it to our > copy. In general, readline's signal handlers will restore any application- installed handlers before resending the signal to itself. This means that any signal can potentially cause an application's handler to be called, and longjmp to be called from that. Now we would be relying on the application's signal handler to restore the appropriate readline state. Chet -- ``The lyf so short, the craft so long to lerne.'' - Chaucer Live Strong. No day but today. Chet Ramey, ITS, CWRU chet@case.edu http://cnswww.cns.cwru.edu/~chet/