[cosmetic-patch] missing declaration in monitor.c

[cosmetic-patch] missing declaration in monitor.c

[Denis PILAT]

monitor_insert_breakpoint and monitor_remove_breakpoint used to be 
declared with other static function.

-- 
Denis

Index: monitor.c
===================================================================
--- monitor.c   (revision 486)
+++ monitor.c   (working copy)
@@ -85,6 +85,8 @@ static int monitor_xfer_memory (CORE_ADD
                                struct mem_attrib *attrib,
                                struct target_ops *target);
 static void monitor_files_info (struct target_ops *ops);
+static int monitor_insert_breakpoint (struct bp_target_info *bp_tgt);
+static int monitor_remove_breakpoint (struct bp_target_info *bp_tgt);
 static void monitor_kill (void);
 static void monitor_load (char *file, int from_tty);
 static void monitor_mourn_inferior (void);

Re: [cosmetic-patch] missing declaration in monitor.c

[Daniel Jacobowitz]

On Mon, Jul 17, 2006 at 01:31:39PM +0200, Denis PILAT wrote:
> monitor_insert_breakpoint and monitor_remove_breakpoint used to be 
> declared with other static function.

Yes, I deliberately removed the prototypes instead of changing them.
Did you need them back for a reason?  There's no advantage in modern
C to prototyping a static function if it is not used before it is
defined.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [cosmetic-patch] missing declaration in monitor.c

[Denis PILAT]

Daniel Jacobowitz wrote:

>On Mon, Jul 17, 2006 at 01:31:39PM +0200, Denis PILAT wrote:
>  
>
>>monitor_insert_breakpoint and monitor_remove_breakpoint used to be 
>>declared with other static function.
>>    
>>
>
>Yes, I deliberately removed the prototypes instead of changing them.
>Did you need them back for a reason?  There's no advantage in modern
>C to prototyping a static function if it is not used before it is
>defined.
>
>  
>
No I don't need them.
While reading the code I found that they were missing because all other 
static function are declared.
I'm wondering why you remove only these 2 one ? Most of static functions 
are not used before beeing defined.

Re: [cosmetic-patch] missing declaration in monitor.c

[Daniel Jacobowitz]

On Mon, Jul 17, 2006 at 02:50:05PM +0200, Denis PILAT wrote:
> No I don't need them.
> While reading the code I found that they were missing because all other 
> static function are declared.
> I'm wondering why you remove only these 2 one ? Most of static functions 
> are not used before beeing defined.

I removed those two because I was changing them - the old ones were
wrong.  It's a bit of work to make sure that a prototype isn't
necessary.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [cosmetic-patch] missing declaration in monitor.c

[Mark Kettenis]

> Date: Mon, 17 Jul 2006 09:43:58 -0400
> From: Daniel Jacobowitz <drow@false.org>
> 
> On Mon, Jul 17, 2006 at 02:50:05PM +0200, Denis PILAT wrote:
> > No I don't need them.
> > While reading the code I found that they were missing because all other 
> > static function are declared.
> > I'm wondering why you remove only these 2 one ? Most of static functions 
> > are not used before beeing defined.
> 
> I removed those two because I was changing them - the old ones were
> wrong.  It's a bit of work to make sure that a prototype isn't
> necessary.

But you're encouraged to remove redundant prototypes if you happen to
see them ;-).

Mark

Re: [cosmetic-patch] missing declaration in monitor.c

[Daniel Jacobowitz]

On Tue, Jul 18, 2006 at 10:25:35AM +0200, Denis PILAT wrote:
> <tt>I sent a patch to Daniel yesterday where all useless prototypes are removed.<br>
> Cf attached message.<br>

Two things: please don't use HTML mail on this list, and please try to
use a mailer which won't completely mangle patches.  It had been line
wrapped and some tabs were converted to spaces.

Anyway, the patch looks fine; thanks.  I've checked it in with this
ChangeLog entry:

2006-07-18  Denis PILAT  <denis.pilat@st.com>

        * monitor.c: Remove unused prototypes.

-- 
Daniel Jacobowitz
CodeSourcery