From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10962 invoked by alias); 17 Jul 2006 12:50:21 -0000 Received: (qmail 10943 invoked by uid 22791); 17 Jul 2006 12:50:19 -0000 X-Spam-Check-By: sourceware.org Received: from fra-del-03.spheriq.net (HELO fra-del-03.spheriq.net) (195.46.51.99) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 17 Jul 2006 12:50:16 +0000 Received: from fra-out-03.spheriq.net (fra-out-03.spheriq.net [195.46.51.131]) by fra-del-03.spheriq.net with ESMTP id k6HCoDI3030471 for ; Mon, 17 Jul 2006 12:50:13 GMT Received: from fra-cus-02.spheriq.net (fra-cus-02.spheriq.net [195.46.51.38]) by fra-out-03.spheriq.net with ESMTP id k6HCoDmh025267 for ; Mon, 17 Jul 2006 12:50:13 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by fra-cus-02.spheriq.net with ESMTP id k6HCoANN015071 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Mon, 17 Jul 2006 12:50:12 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 0E8A3DA4B; Mon, 17 Jul 2006 12:50:07 +0000 (GMT) Received: from mail1.cro.st.com (mail1.cro.st.com [164.129.40.131]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id A74224760E; Mon, 17 Jul 2006 12:50:06 +0000 (GMT) Received: from st.com (crx1177.cro.st.com [164.129.47.77]) by mail1.cro.st.com (MOS 3.5.8-GR) with ESMTP id CHZ49348 (AUTH "denis pilat"); Mon, 17 Jul 2006 14:50:05 +0200 (CEST) Message-ID: <44BB877C.1050003@st.com> Date: Mon, 17 Jul 2006 12:50:00 -0000 From: Denis PILAT User-Agent: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.0.1) Gecko/20020920 Netscape/7.0 MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [cosmetic-patch] missing declaration in monitor.c References: <44BB751B.10608@st.com> <20060717123228.GA8764@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00201.txt.bz2 Daniel Jacobowitz wrote: >On Mon, Jul 17, 2006 at 01:31:39PM +0200, Denis PILAT wrote: > > >>monitor_insert_breakpoint and monitor_remove_breakpoint used to be >>declared with other static function. >> >> > >Yes, I deliberately removed the prototypes instead of changing them. >Did you need them back for a reason? There's no advantage in modern >C to prototyping a static function if it is not used before it is >defined. > > > No I don't need them. While reading the code I found that they were missing because all other static function are declared. I'm wondering why you remove only these 2 one ? Most of static functions are not used before beeing defined.