From: Denis PILAT <denis.pilat@st.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [cosmetic-patch] missing declaration in monitor.c
Date: Mon, 17 Jul 2006 12:50:00 -0000 [thread overview]
Message-ID: <44BB877C.1050003@st.com> (raw)
In-Reply-To: <20060717123228.GA8764@nevyn.them.org>
Daniel Jacobowitz wrote:
>On Mon, Jul 17, 2006 at 01:31:39PM +0200, Denis PILAT wrote:
>
>
>>monitor_insert_breakpoint and monitor_remove_breakpoint used to be
>>declared with other static function.
>>
>>
>
>Yes, I deliberately removed the prototypes instead of changing them.
>Did you need them back for a reason? There's no advantage in modern
>C to prototyping a static function if it is not used before it is
>defined.
>
>
>
No I don't need them.
While reading the code I found that they were missing because all other
static function are declared.
I'm wondering why you remove only these 2 one ? Most of static functions
are not used before beeing defined.
next prev parent reply other threads:[~2006-07-17 12:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-17 11:31 Denis PILAT
2006-07-17 12:32 ` Daniel Jacobowitz
2006-07-17 12:50 ` Denis PILAT [this message]
2006-07-17 13:44 ` Daniel Jacobowitz
2006-07-17 18:01 ` Mark Kettenis
[not found] ` <44BC9AFF.9020906@st.com>
2006-07-18 20:46 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44BB877C.1050003@st.com \
--to=denis.pilat@st.com \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox