From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26461 invoked by alias); 17 Jul 2006 13:44:03 -0000 Received: (qmail 26452 invoked by uid 22791); 17 Jul 2006 13:44:02 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 17 Jul 2006 13:44:00 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1G2TOA-0002j0-HF; Mon, 17 Jul 2006 09:43:58 -0400 Date: Mon, 17 Jul 2006 13:44:00 -0000 From: Daniel Jacobowitz To: Denis PILAT Cc: gdb-patches@sources.redhat.com Subject: Re: [cosmetic-patch] missing declaration in monitor.c Message-ID: <20060717134358.GA10443@nevyn.them.org> Mail-Followup-To: Denis PILAT , gdb-patches@sources.redhat.com References: <44BB751B.10608@st.com> <20060717123228.GA8764@nevyn.them.org> <44BB877C.1050003@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44BB877C.1050003@st.com> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00202.txt.bz2 On Mon, Jul 17, 2006 at 02:50:05PM +0200, Denis PILAT wrote: > No I don't need them. > While reading the code I found that they were missing because all other > static function are declared. > I'm wondering why you remove only these 2 one ? Most of static functions > are not used before beeing defined. I removed those two because I was changing them - the old ones were wrong. It's a bit of work to make sure that a prototype isn't necessary. -- Daniel Jacobowitz CodeSourcery