From: Michael Snyder <msnyder@redhat.com>
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] update "info scope" with new symtypes
Date: Tue, 11 May 2004 22:43:00 -0000 [thread overview]
Message-ID: <40A156F1.8050407@redhat.com> (raw)
In-Reply-To: <409D045D.90207@gnu.org>
Andrew Cagney wrote:
Andrew Cagney wrote:
Add LOC_COMPUTED etc. to scope_info.
Michael, most of this patch is white space changes and as such should
separated out and committed separatly.
Andrew, I could understand your objection if this were a
request for review, but since it's a patch that I'm checking
in directly,
Sorry, I don't understand. We're expected to apply standards uniformly
(here minimizing white space) be it peer review or self-review.
We're even -- I don't understand either. Minimizing white space?
Anyway, this discussion occurred in 2000 -- I've reviewed it,
and it was entirely concerned with the difficulty of *reviewing*
patches that included mixed code and whitespace changes.
Since then, mixed changes that don't have to be reviewed have
frequently been posted without attracting comment.
next prev parent reply other threads:[~2004-05-11 22:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-07 21:28 Michael Snyder
2004-05-07 22:55 ` Andrew Cagney
2004-05-08 3:50 ` Michael Snyder
2004-05-08 16:01 ` Andrew Cagney
2004-05-11 22:43 ` Michael Snyder [this message]
2004-05-11 22:55 ` Andrew Cagney
2004-05-12 0:20 ` Michael Snyder
2004-05-14 13:59 ` Andrew Cagney
2004-05-14 18:41 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40A156F1.8050407@redhat.com \
--to=msnyder@redhat.com \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox