From: Andrew Cagney <cagney@gnu.org>
To: Michael Snyder <msnyder@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] update "info scope" with new symtypes
Date: Fri, 07 May 2004 22:55:00 -0000 [thread overview]
Message-ID: <409C13DB.6010409@gnu.org> (raw)
In-Reply-To: <409BFF70.8020304@redhat.com>
> Add LOC_COMPUTED etc. to scope_info.
Michael, most of this patch is white space changes and as such should
separated out and committed separatly.
Andrew
> Index: tracepoint.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/tracepoint.c,v
> retrieving revision 1.59
> diff -p -r1.59 tracepoint.c
> *** tracepoint.c 28 Apr 2004 16:36:25 -0000 1.59
> --- tracepoint.c 7 May 2004 21:26:22 -0000
> *************** scope_info (char *args, int from_tty)
> *** 2345,2351 ****
>
> sals = decode_line_1 (&args, 1, NULL, 0, &canonical, NULL);
> if (sals.nelts == 0)
> ! return; /* presumably decode_line_1 has already warned */
>
> /* Resolve line numbers to PC */
> resolve_sal_pc (&sals.sals[0]);
> --- 2345,2351 ----
>
> sals = decode_line_1 (&args, 1, NULL, 0, &canonical, NULL);
> if (sals.nelts == 0)
> ! return; /* presumably decode_line_1 has already warned */
>
> /* Resolve line numbers to PC */
> resolve_sal_pc (&sals.sals[0]);
> *************** scope_info (char *args, int from_tty)
> *** 2387,2393 ****
> break;
> case LOC_STATIC:
> printf_filtered ("in static storage at address ");
> ! print_address_numeric (SYMBOL_VALUE_ADDRESS (sym), 1, gdb_stdout);
> break;
> case LOC_REGISTER:
> printf_filtered ("a local variable in register $%s",
> --- 2387,2394 ----
> break;
> case LOC_STATIC:
> printf_filtered ("in static storage at address ");
> ! print_address_numeric (SYMBOL_VALUE_ADDRESS (sym),
> ! 1, gdb_stdout);
> break;
> case LOC_REGISTER:
> printf_filtered ("a local variable in register $%s",
> *************** scope_info (char *args, int from_tty)
> *** 2419,2430 ****
> continue;
> case LOC_LABEL:
> printf_filtered ("a label at address ");
> ! print_address_numeric (SYMBOL_VALUE_ADDRESS (sym), 1, gdb_stdout);
> break;
> case LOC_BLOCK:
> printf_filtered ("a function at address ");
> ! print_address_numeric (BLOCK_START (SYMBOL_BLOCK_VALUE (sym)), 1,
> ! gdb_stdout);
> break;
> case LOC_BASEREG:
> printf_filtered ("a variable at offset %ld from register $%s",
> --- 2420,2432 ----
> continue;
> case LOC_LABEL:
> printf_filtered ("a label at address ");
> ! print_address_numeric (SYMBOL_VALUE_ADDRESS (sym),
> ! 1, gdb_stdout);
> break;
> case LOC_BLOCK:
> printf_filtered ("a function at address ");
> ! print_address_numeric (BLOCK_START (SYMBOL_BLOCK_VALUE (sym)),
> ! 1, gdb_stdout);
> break;
> case LOC_BASEREG:
> printf_filtered ("a variable at offset %ld from register $%s",
> *************** scope_info (char *args, int from_tty)
> *** 2437,2443 ****
> REGISTER_NAME (SYMBOL_BASEREG (sym)));
> break;
> case LOC_UNRESOLVED:
> ! msym = lookup_minimal_symbol (DEPRECATED_SYMBOL_NAME (sym), NULL, NULL);
> if (msym == NULL)
> printf_filtered ("Unresolved Static");
> else
> --- 2439,2446 ----
> REGISTER_NAME (SYMBOL_BASEREG (sym)));
> break;
> case LOC_UNRESOLVED:
> ! msym = lookup_minimal_symbol (DEPRECATED_SYMBOL_NAME (sym),
> ! NULL, NULL);
> if (msym == NULL)
> printf_filtered ("Unresolved Static");
> else
> *************** scope_info (char *args, int from_tty)
> *** 2450,2459 ****
> case LOC_OPTIMIZED_OUT:
> printf_filtered ("optimized out.\n");
> continue;
> }
> if (SYMBOL_TYPE (sym))
> printf_filtered (", length %d.\n",
> ! TYPE_LENGTH (check_typedef (SYMBOL_TYPE (sym))));
> }
> if (BLOCK_FUNCTION (block))
> break;
> --- 2453,2474 ----
> case LOC_OPTIMIZED_OUT:
> printf_filtered ("optimized out.\n");
> continue;
> }
> if (SYMBOL_TYPE (sym))
> printf_filtered (", length %d.\n",
> ! TYPE_LENGTH (check_typedef (SYMBOL_TYPE (sym))));
> }
> if (BLOCK_FUNCTION (block))
> break;
next prev parent reply other threads:[~2004-05-07 22:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-07 21:28 Michael Snyder
2004-05-07 22:55 ` Andrew Cagney [this message]
2004-05-08 3:50 ` Michael Snyder
2004-05-08 16:01 ` Andrew Cagney
2004-05-11 22:43 ` Michael Snyder
2004-05-11 22:55 ` Andrew Cagney
2004-05-12 0:20 ` Michael Snyder
2004-05-14 13:59 ` Andrew Cagney
2004-05-14 18:41 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=409C13DB.6010409@gnu.org \
--to=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox