From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6372 invoked by alias); 7 May 2004 22:55:32 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6351 invoked from network); 7 May 2004 22:55:31 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 7 May 2004 22:55:31 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i47MtT0o003055 for ; Fri, 7 May 2004 18:55:31 -0400 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i47MtTv19927; Fri, 7 May 2004 18:55:29 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 1B6172B9D; Fri, 7 May 2004 18:55:24 -0400 (EDT) Message-ID: <409C13DB.6010409@gnu.org> Date: Fri, 07 May 2004 22:55:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Michael Snyder Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] update "info scope" with new symtypes References: <409BFF70.8020304@redhat.com> In-Reply-To: <409BFF70.8020304@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-05/txt/msg00224.txt.bz2 > Add LOC_COMPUTED etc. to scope_info. Michael, most of this patch is white space changes and as such should separated out and committed separatly. Andrew > Index: tracepoint.c > =================================================================== > RCS file: /cvs/src/src/gdb/tracepoint.c,v > retrieving revision 1.59 > diff -p -r1.59 tracepoint.c > *** tracepoint.c 28 Apr 2004 16:36:25 -0000 1.59 > --- tracepoint.c 7 May 2004 21:26:22 -0000 > *************** scope_info (char *args, int from_tty) > *** 2345,2351 **** > > sals = decode_line_1 (&args, 1, NULL, 0, &canonical, NULL); > if (sals.nelts == 0) > ! return; /* presumably decode_line_1 has already warned */ > > /* Resolve line numbers to PC */ > resolve_sal_pc (&sals.sals[0]); > --- 2345,2351 ---- > > sals = decode_line_1 (&args, 1, NULL, 0, &canonical, NULL); > if (sals.nelts == 0) > ! return; /* presumably decode_line_1 has already warned */ > > /* Resolve line numbers to PC */ > resolve_sal_pc (&sals.sals[0]); > *************** scope_info (char *args, int from_tty) > *** 2387,2393 **** > break; > case LOC_STATIC: > printf_filtered ("in static storage at address "); > ! print_address_numeric (SYMBOL_VALUE_ADDRESS (sym), 1, gdb_stdout); > break; > case LOC_REGISTER: > printf_filtered ("a local variable in register $%s", > --- 2387,2394 ---- > break; > case LOC_STATIC: > printf_filtered ("in static storage at address "); > ! print_address_numeric (SYMBOL_VALUE_ADDRESS (sym), > ! 1, gdb_stdout); > break; > case LOC_REGISTER: > printf_filtered ("a local variable in register $%s", > *************** scope_info (char *args, int from_tty) > *** 2419,2430 **** > continue; > case LOC_LABEL: > printf_filtered ("a label at address "); > ! print_address_numeric (SYMBOL_VALUE_ADDRESS (sym), 1, gdb_stdout); > break; > case LOC_BLOCK: > printf_filtered ("a function at address "); > ! print_address_numeric (BLOCK_START (SYMBOL_BLOCK_VALUE (sym)), 1, > ! gdb_stdout); > break; > case LOC_BASEREG: > printf_filtered ("a variable at offset %ld from register $%s", > --- 2420,2432 ---- > continue; > case LOC_LABEL: > printf_filtered ("a label at address "); > ! print_address_numeric (SYMBOL_VALUE_ADDRESS (sym), > ! 1, gdb_stdout); > break; > case LOC_BLOCK: > printf_filtered ("a function at address "); > ! print_address_numeric (BLOCK_START (SYMBOL_BLOCK_VALUE (sym)), > ! 1, gdb_stdout); > break; > case LOC_BASEREG: > printf_filtered ("a variable at offset %ld from register $%s", > *************** scope_info (char *args, int from_tty) > *** 2437,2443 **** > REGISTER_NAME (SYMBOL_BASEREG (sym))); > break; > case LOC_UNRESOLVED: > ! msym = lookup_minimal_symbol (DEPRECATED_SYMBOL_NAME (sym), NULL, NULL); > if (msym == NULL) > printf_filtered ("Unresolved Static"); > else > --- 2439,2446 ---- > REGISTER_NAME (SYMBOL_BASEREG (sym))); > break; > case LOC_UNRESOLVED: > ! msym = lookup_minimal_symbol (DEPRECATED_SYMBOL_NAME (sym), > ! NULL, NULL); > if (msym == NULL) > printf_filtered ("Unresolved Static"); > else > *************** scope_info (char *args, int from_tty) > *** 2450,2459 **** > case LOC_OPTIMIZED_OUT: > printf_filtered ("optimized out.\n"); > continue; > } > if (SYMBOL_TYPE (sym)) > printf_filtered (", length %d.\n", > ! TYPE_LENGTH (check_typedef (SYMBOL_TYPE (sym)))); > } > if (BLOCK_FUNCTION (block)) > break; > --- 2453,2474 ---- > case LOC_OPTIMIZED_OUT: > printf_filtered ("optimized out.\n"); > continue; > } > if (SYMBOL_TYPE (sym)) > printf_filtered (", length %d.\n", > ! TYPE_LENGTH (check_typedef (SYMBOL_TYPE (sym)))); > } > if (BLOCK_FUNCTION (block)) > break;