From: Michael Snyder <msnyder@redhat.com>
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] update "info scope" with new symtypes
Date: Wed, 12 May 2004 00:20:00 -0000 [thread overview]
Message-ID: <40A16DD3.9080503@redhat.com> (raw)
In-Reply-To: <40A159CA.70809@gnu.org>
Andrew Cagney wrote:
>>
>> Anyway, this discussion occurred in 2000 -- I've reviewed it,
>> and it was entirely concerned with the difficulty of *reviewing*
>> patches that included mixed code and whitespace changes.
>
>
>
> Right, and _every_ patch, gets reviewed. It's just that some get
self-reviewed rather than peer-reviwed.
That's clear. I self-reviewed this one, and my
white-space changes did not cause me any discomfort.
> Either way, the contributor is
> expected to meet the same standards.
Andrew, I think you make these 'standards' up to suit your whim.
One thing I know is, I never voted on the one you're claiming
now. The discussion I took part in was about the difficulty of
reviewing other people's patches.
> What we definitly do not do is apply lower standards to self-reviewed
patches.
No? Then how come you made no comment about these patches?
http://sources.redhat.com/ml/gdb-patches/2002-01/msg00040.htm
http://sources.redhat.com/ml/gdb-patches/2002-01/msg00430.html
http://sources.redhat.com/ml/gdb-patches/2002-05/msg00500.html
http://sources.redhat.com/ml/gdb-patches/2002-08/msg00905.html
http://sources.redhat.com/ml/gdb-patches/2003-08/msg00404.html
http://sources.redhat.com/ml/gdb-patches/2003-08/msg00413.html
http://sources.redhat.com/ml/gdb-patches/2004-01/msg00663.html
next prev parent reply other threads:[~2004-05-12 0:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-07 21:28 Michael Snyder
2004-05-07 22:55 ` Andrew Cagney
2004-05-08 3:50 ` Michael Snyder
2004-05-08 16:01 ` Andrew Cagney
2004-05-11 22:43 ` Michael Snyder
2004-05-11 22:55 ` Andrew Cagney
2004-05-12 0:20 ` Michael Snyder [this message]
2004-05-14 13:59 ` Andrew Cagney
2004-05-14 18:41 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40A16DD3.9080503@redhat.com \
--to=msnyder@redhat.com \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox