From: Michael Snyder <msnyder@redhat.com>
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] update "info scope" with new symtypes
Date: Fri, 14 May 2004 18:41:00 -0000 [thread overview]
Message-ID: <40A512D4.3090105@redhat.com> (raw)
In-Reply-To: <40A4D0AF.3060902@gnu.org>
Andrew Cagney wrote:
Add LOC_COMPUTED etc. to scope_info.
Michael, most of this patch is white space changes and as such should
separated out and committed separatly.
Michael, I appologise for my very poor choice of words.
We've previously all agreed that it is helpful to commit whitespace
changes separately; it's easier to sort things out when looking at CVS
diffs later on. Could you do that?
Andrew, I don't agree that we have all agreed to what you say.
What I recall discussing (and my review of the mail archive
bears out my recollection) is that it is helpful if submissions
for review have whitespace changes separated out, becuase
otherwise they are difficult to review.
I also did not find any examples where you previously asked a
global maintainer to redo a mixed patch to a file that he or she
maintained. I did, OTOH, find at least seven examples where a
maintainer had committed such a patch, and nobody said anything
about it. I posted links to those patches.
I think you are proposing a new standard. I'm not committed
to opposing that standard, but it is new, and I think warrants
discussion by the group. If the group agrees to that standard,
I will be happy to abide by it. But standards should be set
by the group, not by one person.
Wouldn't you agree?
prev parent reply other threads:[~2004-05-14 18:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-07 21:28 Michael Snyder
2004-05-07 22:55 ` Andrew Cagney
2004-05-08 3:50 ` Michael Snyder
2004-05-08 16:01 ` Andrew Cagney
2004-05-11 22:43 ` Michael Snyder
2004-05-11 22:55 ` Andrew Cagney
2004-05-12 0:20 ` Michael Snyder
2004-05-14 13:59 ` Andrew Cagney
2004-05-14 18:41 ` Michael Snyder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40A512D4.3090105@redhat.com \
--to=msnyder@redhat.com \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox