From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Snyder To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] update "info scope" with new symtypes Date: Tue, 11 May 2004 22:43:00 -0000 Message-id: <40A156F1.8050407@redhat.com> References: <409BFF70.8020304@redhat.com> <409C13DB.6010409@gnu.org> <409C58E7.60204@redhat.com> <409D045D.90207@gnu.org> X-SW-Source: 2004-05/msg00348.html Andrew Cagney wrote: Andrew Cagney wrote: Add LOC_COMPUTED etc. to scope_info. Michael, most of this patch is white space changes and as such should separated out and committed separatly. Andrew, I could understand your objection if this were a request for review, but since it's a patch that I'm checking in directly, Sorry, I don't understand. We're expected to apply standards uniformly (here minimizing white space) be it peer review or self-review. We're even -- I don't understand either. Minimizing white space? Anyway, this discussion occurred in 2000 -- I've reviewed it, and it was entirely concerned with the difficulty of *reviewing* patches that included mixed code and whitespace changes. Since then, mixed changes that don't have to be reviewed have frequently been posted without attracting comment.