* [ob] frv/sim testsuite tweak
@ 2003-09-11 18:40 Michael Snyder
2003-09-11 18:46 ` Dave Brolley
0 siblings, 1 reply; 6+ messages in thread
From: Michael Snyder @ 2003-09-11 18:40 UTC (permalink / raw)
To: gdb-patches; +Cc: Dave Brolley
[-- Attachment #1: Type: text/plain, Size: 85 bytes --]
Inferring the intent from the comments, this test is
redundant without this change.
[-- Attachment #2: movgs.tmp --]
[-- Type: text/plain, Size: 892 bytes --]
2003-09-11 Michael Snyder <msnyder@redhat.com>
* sim/testsuite/sim/frv/movgs.cgs: Change lcr to spr[273],
which according to the comments seems to be the intent.
Index: sim/frv/movgs.cgs
===================================================================
RCS file: /cvs/src/src/sim/testsuite/sim/frv/movgs.cgs,v
retrieving revision 1.1
diff -p -r1.1 movgs.cgs
*** sim/frv/movgs.cgs 29 Aug 2003 16:41:31 -0000 1.1
--- sim/frv/movgs.cgs 11 Sep 2003 18:37:54 -0000
*************** movgs:
*** 15,21 ****
; try alternate names for lcr
and_spr_immed 0,273
! movgs gr8,lcr ; lcr is spr number 273
test_gr_limmed 0xdead,0xbeef,gr8
test_spr_limmed 0xdead,0xbeef,spr[273]
--- 15,21 ----
; try alternate names for lcr
and_spr_immed 0,273
! movgs gr8,spr[273] ; lcr is spr number 273
test_gr_limmed 0xdead,0xbeef,gr8
test_spr_limmed 0xdead,0xbeef,spr[273]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ob] frv/sim testsuite tweak
2003-09-11 18:40 [ob] frv/sim testsuite tweak Michael Snyder
@ 2003-09-11 18:46 ` Dave Brolley
2003-09-11 19:10 ` Michael Snyder
0 siblings, 1 reply; 6+ messages in thread
From: Dave Brolley @ 2003-09-11 18:46 UTC (permalink / raw)
To: Michael Snyder; +Cc: gdb-patches
Michael, please revert this change. This test uses several different
notations to reference the lcr register and one of them is 'lcr'. As you
can see spr[273] is tested a few lines later.
Thanks,
Dave
Michael Snyder wrote:
> Inferring the intent from the comments, this test is
> redundant without this change.
>
>------------------------------------------------------------------------
>
>2003-09-11 Michael Snyder <msnyder@redhat.com>
>
> * sim/testsuite/sim/frv/movgs.cgs: Change lcr to spr[273],
> which according to the comments seems to be the intent.
>
>Index: sim/frv/movgs.cgs
>===================================================================
>RCS file: /cvs/src/src/sim/testsuite/sim/frv/movgs.cgs,v
>retrieving revision 1.1
>diff -p -r1.1 movgs.cgs
>*** sim/frv/movgs.cgs 29 Aug 2003 16:41:31 -0000 1.1
>--- sim/frv/movgs.cgs 11 Sep 2003 18:37:54 -0000
>*************** movgs:
>*** 15,21 ****
>
> ; try alternate names for lcr
> and_spr_immed 0,273
>! movgs gr8,lcr ; lcr is spr number 273
> test_gr_limmed 0xdead,0xbeef,gr8
> test_spr_limmed 0xdead,0xbeef,spr[273]
>
>--- 15,21 ----
>
> ; try alternate names for lcr
> and_spr_immed 0,273
>! movgs gr8,spr[273] ; lcr is spr number 273
> test_gr_limmed 0xdead,0xbeef,gr8
> test_spr_limmed 0xdead,0xbeef,spr[273]
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ob] frv/sim testsuite tweak
2003-09-11 18:46 ` Dave Brolley
@ 2003-09-11 19:10 ` Michael Snyder
2003-09-11 19:36 ` Dave Brolley
0 siblings, 1 reply; 6+ messages in thread
From: Michael Snyder @ 2003-09-11 19:10 UTC (permalink / raw)
To: Dave Brolley; +Cc: gdb-patches
Dave Brolley wrote:
> Michael, please revert this change. This test uses several different
> notations to reference the lcr register and one of them is 'lcr'. As you
> can see spr[273] is tested a few lines later.
Yeah, but 'lcr' had already been tested (twice) above.
If I revert it, then the exact same line,
movgs gr8, lcr
is tested twice, while
movgs gr8, spr[273]
is not tested at all.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ob] frv/sim testsuite tweak
2003-09-11 19:10 ` Michael Snyder
@ 2003-09-11 19:36 ` Dave Brolley
2003-09-11 19:52 ` Michael Snyder
0 siblings, 1 reply; 6+ messages in thread
From: Dave Brolley @ 2003-09-11 19:36 UTC (permalink / raw)
To: Michael Snyder; +Cc: gdb-patches
Michael Snyder wrote:
> Dave Brolley wrote:
>
>> Michael, please revert this change. This test uses several different
>> notations to reference the lcr register and one of them is 'lcr'. As
>> you can see spr[273] is tested a few lines later.
>
>
> Yeah, but 'lcr' had already been tested (twice) above.
> If I revert it, then the exact same line,
> movgs gr8, lcr
> is tested twice, while
> movgs gr8, spr[273]
> is not tested at all.
OK. Now that I look at the entire test case, I see that this patch is
correct.
Dave
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ob] frv/sim testsuite tweak
2003-09-11 19:36 ` Dave Brolley
@ 2003-09-11 19:52 ` Michael Snyder
2003-09-12 16:14 ` Dave Brolley
0 siblings, 1 reply; 6+ messages in thread
From: Michael Snyder @ 2003-09-11 19:52 UTC (permalink / raw)
To: Dave Brolley; +Cc: gdb-patches
Dave Brolley wrote:
> Michael Snyder wrote:
>
>> Dave Brolley wrote:
>>
>>> Michael, please revert this change. This test uses several different
>>> notations to reference the lcr register and one of them is 'lcr'. As
>>> you can see spr[273] is tested a few lines later.
>>
>>
>>
>> Yeah, but 'lcr' had already been tested (twice) above.
>> If I revert it, then the exact same line,
>> movgs gr8, lcr
>> is tested twice, while
>> movgs gr8, spr[273]
>> is not tested at all.
>
>
> OK. Now that I look at the entire test case, I see that this patch is
> correct.
Of course, you could argue that we need to make sure that
lcr is identical with spr[273]. Would you like me to add
a third clause in which we store to lcr and retrieve from
spr[273]?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ob] frv/sim testsuite tweak
2003-09-11 19:52 ` Michael Snyder
@ 2003-09-12 16:14 ` Dave Brolley
0 siblings, 0 replies; 6+ messages in thread
From: Dave Brolley @ 2003-09-12 16:14 UTC (permalink / raw)
To: Michael Snyder; +Cc: gdb-patches
Michael Snyder wrote:
> Dave Brolley wrote:
>
>> Michael Snyder wrote:
>>
>>> Dave Brolley wrote:
>>>
>>>> Michael, please revert this change. This test uses several
>>>> different notations to reference the lcr register and one of them
>>>> is 'lcr'. As you can see spr[273] is tested a few lines later.
>>>
>>>
>>>
>>>
>>> Yeah, but 'lcr' had already been tested (twice) above.
>>> If I revert it, then the exact same line,
>>> movgs gr8, lcr
>>> is tested twice, while
>>> movgs gr8, spr[273]
>>> is not tested at all.
>>
>>
>>
>> OK. Now that I look at the entire test case, I see that this patch is
>> correct.
>
>
> Of course, you could argue that we need to make sure that
> lcr is identical with spr[273]. Would you like me to add
> a third clause in which we store to lcr and retrieve from
> spr[273]?
Anything which makes a test case more robust is welcome.
Thanks,
Dave
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-09-12 16:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-09-11 18:40 [ob] frv/sim testsuite tweak Michael Snyder
2003-09-11 18:46 ` Dave Brolley
2003-09-11 19:10 ` Michael Snyder
2003-09-11 19:36 ` Dave Brolley
2003-09-11 19:52 ` Michael Snyder
2003-09-12 16:14 ` Dave Brolley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox