From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25470 invoked by alias); 12 Sep 2003 16:14:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25462 invoked from network); 12 Sep 2003 16:14:19 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 12 Sep 2003 16:14:19 -0000 Received: from redhat.com (vpn50-26.rdu.redhat.com [172.16.50.26]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 18A17800348; Fri, 12 Sep 2003 12:14:16 -0400 (EDT) Message-ID: <3F61F11C.3050907@redhat.com> Date: Fri, 12 Sep 2003 16:14:00 -0000 From: Dave Brolley User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.2) Gecko/20021216 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Michael Snyder Cc: gdb-patches@sources.redhat.com Subject: Re: [ob] frv/sim testsuite tweak References: <3F60C1AF.7070500@redhat.com> <3F60C34F.8000406@redhat.com> <3F60C8A8.5050405@redhat.com> <3F60CF12.4000403@redhat.com> <3F60D267.1090207@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-09/txt/msg00262.txt.bz2 Michael Snyder wrote: > Dave Brolley wrote: > >> Michael Snyder wrote: >> >>> Dave Brolley wrote: >>> >>>> Michael, please revert this change. This test uses several >>>> different notations to reference the lcr register and one of them >>>> is 'lcr'. As you can see spr[273] is tested a few lines later. >>> >>> >>> >>> >>> Yeah, but 'lcr' had already been tested (twice) above. >>> If I revert it, then the exact same line, >>> movgs gr8, lcr >>> is tested twice, while >>> movgs gr8, spr[273] >>> is not tested at all. >> >> >> >> OK. Now that I look at the entire test case, I see that this patch is >> correct. > > > Of course, you could argue that we need to make sure that > lcr is identical with spr[273]. Would you like me to add > a third clause in which we store to lcr and retrieve from > spr[273]? Anything which makes a test case more robust is welcome. Thanks, Dave