From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29805 invoked by alias); 11 Sep 2003 19:52:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29798 invoked from network); 11 Sep 2003 19:52:18 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 11 Sep 2003 19:52:18 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h8BJqGl20491 for ; Thu, 11 Sep 2003 15:52:17 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h8BJqAL32332 for ; Thu, 11 Sep 2003 15:52:15 -0400 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h8BJq7w19629; Thu, 11 Sep 2003 12:52:07 -0700 Message-ID: <3F60D267.1090207@redhat.com> Date: Thu, 11 Sep 2003 19:52:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Dave Brolley CC: gdb-patches@sources.redhat.com Subject: Re: [ob] frv/sim testsuite tweak References: <3F60C1AF.7070500@redhat.com> <3F60C34F.8000406@redhat.com> <3F60C8A8.5050405@redhat.com> <3F60CF12.4000403@redhat.com> In-Reply-To: <3F60CF12.4000403@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-09/txt/msg00240.txt.bz2 Dave Brolley wrote: > Michael Snyder wrote: > >> Dave Brolley wrote: >> >>> Michael, please revert this change. This test uses several different >>> notations to reference the lcr register and one of them is 'lcr'. As >>> you can see spr[273] is tested a few lines later. >> >> >> >> Yeah, but 'lcr' had already been tested (twice) above. >> If I revert it, then the exact same line, >> movgs gr8, lcr >> is tested twice, while >> movgs gr8, spr[273] >> is not tested at all. > > > OK. Now that I look at the entire test case, I see that this patch is > correct. Of course, you could argue that we need to make sure that lcr is identical with spr[273]. Would you like me to add a third clause in which we store to lcr and retrieve from spr[273]?